[Feature][task-plugins-12820] azure azure-sql datasource plugins#2
Closed
Tianqi-Dotes wants to merge 11 commits intodevfrom
Closed
[Feature][task-plugins-12820] azure azure-sql datasource plugins#2Tianqi-Dotes wants to merge 11 commits intodevfrom
Tianqi-Dotes wants to merge 11 commits intodevfrom
Conversation
caishunfeng
reviewed
Dec 16, 2022
| return jdbcUrl + ";authentication=" + param.getMode().getDescp(); | ||
| case AD_MSI: | ||
| if (StringUtils.isEmpty(param.getMSIClientId())) { | ||
| return jdbcUrl + ";authentication=" + param.getMode().getDescp(); |
| return jdbcUrl + ";authentication=" + param.getMode().getDescp(); | ||
| } else { | ||
| // write MSIClientId inside jdbc URL so no need MSIClientId in the AzureSQLConnectionParam | ||
| return jdbcUrl + ";authentication=" + param.getMode().getDescp() |
|
|
||
| private void checkTrustServerCertificate(BaseDataSourceParamDTO paramDTO){ | ||
| Map<String, String> other = Optional.ofNullable(paramDTO.getOther()).orElseGet(HashMap::new); | ||
| other.put("trustServerCertificate","true"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
apache#12820
supports 5 auth mode to azure sql
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md