Revert "chore: revert tests (#18065)" #18255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a65a2cb.
dqkqd
commented
Oct 23, 2025
Comment on lines
+45
to
+47
| SELECT current_date() = cast(now() as date); | ||
| ---- | ||
| true |
Contributor
Author
There was a problem hiding this comment.
This was the failed test. See #18062 (comment)
This checks current_date must equal now::date after setting timezone = +05:00.
I verified CI passed around 2025-10-23 20:30PM UTC, which was 2025-10-24 01:30AM UTC+5.
(It had failed around 2025-10-14 20:03PM UTC = 2025-10-15 01:03AM UTC+5)
Weijun-H
approved these changes
Oct 24, 2025
Contributor
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
## Which issue does this PR close? - Relates apache#18062 - Relates apache#18065 ## Rationale for this change We disabled these tests because CI was failing on main. The test: `current_date() = cast(now() as date)` was added in apache#18034 requires `now` to use configured timezone, but it is only available after apache#18017. Since apache#18017 has been merged, these tests should be enable. ## What changes are included in this PR? This reverts commit a65a2cb. ## Are these changes tested? Yes. ## Are there any user-facing changes? No.
EeshanBembi
pushed a commit
to EeshanBembi/datafusion
that referenced
this pull request
Nov 24, 2025
## Which issue does this PR close? - Relates apache#18062 - Relates apache#18065 ## Rationale for this change We disabled these tests because CI was failing on main. The test: `current_date() = cast(now() as date)` was added in apache#18034 requires `now` to use configured timezone, but it is only available after apache#18017. Since apache#18017 has been merged, these tests should be enable. ## What changes are included in this PR? This reverts commit a65a2cb. ## Are these changes tested? Yes. ## Are there any user-facing changes? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
current_date() = cast(now() as date);#18062Rationale for this change
We disabled these tests because CI was failing on main.
The test:
current_date() = cast(now() as date)was added in #18034requires
nowto use configured timezone, but it is only available after #18017.Since #18017 has been merged, these tests should be enable.
What changes are included in this PR?
This reverts commit a65a2cb.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.