Feat: Make current_date aware of execution timezone. #18034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Oct 13, 2025
comphead
reviewed
Oct 13, 2025
comphead
reviewed
Oct 13, 2025
| ); | ||
|
|
||
| // Get timezone from config and convert to local time | ||
| let days = if let Some(config) = info.execution_props().config_options() { |
Contributor
There was a problem hiding this comment.
I think we can rewrite this into something more idiomatic
let days = info
.execution_props()
.config_options()
.and_then(|config| config.execution.time_zone.parse::<Tz>().ok())
.map_or_else(
|| datetime_to_days(&now_ts),
|tz| {
let local_now = tz.from_utc_datetime(&now_ts.naive_utc());
datetime_to_days(&local_now)
},
);
comphead
approved these changes
Oct 14, 2025
Contributor
comphead
left a comment
There was a problem hiding this comment.
Thanks @codetyri0n it looks good to me
alamb
reviewed
Oct 14, 2025
|
|
||
| #Test 4: Verify current_date matches cast(now() as date) in the same timezone | ||
| query B | ||
| SELECT current_date() = cast(now() as date); |
Contributor
There was a problem hiding this comment.
For some reason, this test appears to be failing on main:
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2025
## Which issue does this PR close? - Relates #18062 - Relates #18065 ## Rationale for this change We disabled these tests because CI was failing on main. The test: `current_date() = cast(now() as date)` was added in #18034 requires `now` to use configured timezone, but it is only available after #18017. Since #18017 has been merged, these tests should be enable. ## What changes are included in this PR? This reverts commit a65a2cb. ## Are these changes tested? Yes. ## Are there any user-facing changes? No.
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
* Feat: Make current_date aware of execution timezone. * CI Fixes: Rectify assertion error of slt and update scalar_functions.md * CI Fixes: Comment out flaky test involving now(). * CI Fixes: Resolve slt error. * Feat: Add helper function to calculate current_date and fix tests. * Chore: Refactor timezone conversion logic.
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
## Which issue does this PR close? - Relates apache#18062 - Relates apache#18065 ## Rationale for this change We disabled these tests because CI was failing on main. The test: `current_date() = cast(now() as date)` was added in apache#18034 requires `now` to use configured timezone, but it is only available after apache#18017. Since apache#18017 has been merged, these tests should be enable. ## What changes are included in this PR? This reverts commit a65a2cb. ## Are these changes tested? Yes. ## Are there any user-facing changes? No.
EeshanBembi
pushed a commit
to EeshanBembi/datafusion
that referenced
this pull request
Nov 24, 2025
## Which issue does this PR close? - Relates apache#18062 - Relates apache#18065 ## Rationale for this change We disabled these tests because CI was failing on main. The test: `current_date() = cast(now() as date)` was added in apache#18034 requires `now` to use configured timezone, but it is only available after apache#18017. Since apache#18017 has been merged, these tests should be enable. ## What changes are included in this PR? This reverts commit a65a2cb. ## Are these changes tested? Yes. ## Are there any user-facing changes? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?