Move bit_and_or_xor unit tests to slt #10457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NoeB <noe.brehm@bluewin.ch>
Jefffrey
approved these changes
May 11, 2024
Contributor
Jefffrey
left a comment
There was a problem hiding this comment.
LGTM apart from a minor nit 👍
| create table t (c int) as values (4), (7), (4), (7), (15); | ||
|
|
||
| query IT | ||
| Select bit_xor(DISTINCT c), arrow_typeof(bit_xor(c)) from t; |
Contributor
There was a problem hiding this comment.
Suggested change
| Select bit_xor(DISTINCT c), arrow_typeof(bit_xor(c)) from t; | |
| Select bit_xor(DISTINCT c), arrow_typeof(bit_xor(DISTINCT c)) from t; |
nit: Technically this I think (and same for the below ones)
Contributor
Author
|
@Jefffrey Thank you for the review, I added a new commit which adds the missing distinct for the type |
jayzhan211
approved these changes
May 11, 2024
Contributor
10 tasks
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* move bit_and_or_xor unit tests to slt Signed-off-by: NoeB <noe.brehm@bluewin.ch> * Apply suggestions from code review --------- Signed-off-by: NoeB <noe.brehm@bluewin.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #10384
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?