-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Is your feature request related to a problem or challenge?
There are many rust test that exists in aggregate functions. Moving them to sqllogictest is easier to maintain and avoid additional testing functions like generic_test_op, assert_string_aggregate, assert_aggregate, assert_error_bounds, and so on. It also makes #8708 a lot easier.
#10382 is an example of how tests are moved to.
I think most of them are Good first issue:
- Sum Minor: Move Sum aggregate function test to slt #10382
- Count Minor: Move count test to slt #10383
- average Move average unit tests to slt #10401
- Move bit_and_or_xor unit tests to slt #10457
- min_max
- array_agg
- correlation
- median
- stddev
- variance
Describe the solution you'd like
Port rust test in datafusion/physical-expr/src/aggregate/tdigest.rs to datafusion/sqllogictest/test_files/aggregate.slt
We can just add the test to aggregate.slt even if there is a duplicated test case to make the review easier.
Describe alternatives you've considered
No response
Additional context
No response
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers