Skip to content

Conversation

@jayzhan211
Copy link
Contributor

@jayzhan211 jayzhan211 commented May 5, 2024

Which issue does this PR close?

Part of #8708
Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
@github-actions github-actions bot added physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt) labels May 5, 2024
@jayzhan211 jayzhan211 changed the title Move Sum aggregate function test to slt Minor: Move Sum aggregate function test to slt May 5, 2024
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
@jayzhan211 jayzhan211 marked this pull request as ready for review May 5, 2024 05:31
@jayzhan211 jayzhan211 marked this pull request as draft May 5, 2024 05:31
@jayzhan211 jayzhan211 marked this pull request as ready for review May 5, 2024 12:10
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jayzhan211 -- looks good to me

@alamb alamb merged commit b412dba into apache:main May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants