protect against null-path by DaanHoogland · Pull Request #8915 · apache/cloudstack

DaanHoogland · 2024-04-15T09:05:29Z

Description

This PR...

Fixes: #8747

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

This is not re-produced bug. The fix is fairly simple. I have no idea how to reproduce but it resulted in data loss in a production VM. I think the best we can do is test upgrades from different versions. and see if anything happens.

How did you try to break this feature and the system with this change?

DaanHoogland · 2024-04-15T09:09:51Z

@blueorangutan package

blueorangutan · 2024-04-15T09:12:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

vishesh92

clgtm

blueorangutan · 2024-04-15T09:46:16Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9258

vishesh92

@DaanHoogland a small typo.

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

…vmware/resource/VmwareResource.java Co-authored-by: Vishesh <vishesh92@gmail.com>

DaanHoogland · 2024-04-15T09:50:08Z

@blueorangutan package

blueorangutan · 2024-04-15T09:52:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-15T10:47:16Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9259

vishesh92 · 2024-04-15T10:55:23Z

@blueorangutan test

blueorangutan · 2024-04-15T10:56:03Z

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Pearl1594

code LGTM

blueorangutan · 2024-04-15T21:56:51Z

[SF] Trillian test result (tid-9837)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38030 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8915-t9837-kvm-centos7.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_deploy_vm_with_extraconfig_kvm	`Error`	1.18	test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm	`Error`	1.19	test_deploy_vm_extra_config_data.py
test_02_deploy_vm_on_specific_cluster	`Error`	1.13	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	0.14	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	1.16	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	1.13	test_vm_deployment_planner.py

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

…vmware/resource/VmwareResource.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

DaanHoogland · 2024-04-16T06:28:13Z

@blueorangutan package

blueorangutan · 2024-04-16T06:30:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-16T07:22:43Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9271

DaanHoogland · 2024-04-16T07:30:48Z

@blueorangutan test alma9 vmware-70u3

blueorangutan · 2024-04-16T07:32:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2024-04-16T07:47:49Z

[SF] Trillian Build Failed (tid-9844)

DaanHoogland · 2024-04-16T07:58:56Z

@blueorangutan test rocky8 vmware-70u3

blueorangutan · 2024-04-16T08:00:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

vishesh92

clgtm

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

sureshanaparti

clgtm

…vmware/resource/VmwareResource.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

blueorangutan · 2024-04-16T19:40:04Z

[SF] Trillian test result (tid-9845)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 40143 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8915-t9845-vmware-70u3.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_deploy_vm_with_extraconfig_throws_exception_vmware	`Error`	1.20	test_deploy_vm_extra_config_data.py
test_05_deploy_vm_with_extraconfig_vmware	`Error`	0.19	test_deploy_vm_extra_config_data.py
test_02_deploy_vm_on_specific_cluster	`Error`	1.17	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.20	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	1.21	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	1.17	test_vm_deployment_planner.py

DaanHoogland · 2024-04-17T08:24:28Z

@blueorangutan package

blueorangutan · 2024-04-17T08:26:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-17T09:29:37Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9286

DaanHoogland · 2024-04-17T10:33:02Z

@blueorangutan test alma9 vmware-70u3

blueorangutan · 2024-04-17T10:34:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2024-04-17T23:55:55Z

[SF] Trillian test result (tid-9877)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9
Total time taken: 46074 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8915-t9877-vmware-70u3.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	`Failure`	0.05	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.07	test_ssvm.py

DaanHoogland · 2024-04-18T08:00:16Z

@rajujith any findings?

rajujith

LGTM.

I am unable to reproduce the issue resulting in the 'NULL' path for volume, however, based on the logic in the fix the issue should be fixed.

* 4.18: protect against null-path (#8915) UI: Fix missing locale strings for Status widget (#8792) Add a shutdownhook to remove jobs owned by the process (#8896)

* 4.19: protect against null-path (#8915) UI: Fix missing locale strings for Status widget (#8792) Add a shutdownhook to remove jobs owned by the process (#8896)

Co-authored-by: Vladimir Dombrovski <vladimir.dombrovski@bso.co> Co-authored-by: Vishesh <vishesh92@gmail.com> Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

* 4.18: protect against null-path (apache#8915) UI: Fix missing locale strings for Status widget (apache#8792) Add a shutdownhook to remove jobs owned by the process (apache#8896)

* 4.19: protect against null-path (apache#8915) UI: Fix missing locale strings for Status widget (apache#8792) Add a shutdownhook to remove jobs owned by the process (apache#8896)

vdombrovski and others added 2 commits June 20, 2023 09:38

VR: Fix haproxy log rotation in VR system VM (apache#7587)

2222222

If a request is made to append a file extension to <null>; refuse

600355b

boring-cyborg bot added the component:vmware label Apr 15, 2024

DaanHoogland added component:upgrade component:migration labels Apr 15, 2024

DaanHoogland requested review from Pearl1594, rajujith and vishesh92 April 15, 2024 09:09

DaanHoogland assigned rajujith Apr 15, 2024

DaanHoogland linked an issue Apr 15, 2024 that may be closed by this pull request

ROOT volume got deleted in failure to migrate #8747

Closed

vishesh92 approved these changes Apr 15, 2024

View reviewed changes

vishesh92 requested changes Apr 15, 2024

View reviewed changes

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java Outdated Show resolved Hide resolved

Update plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/…

9fafab6

…vmware/resource/VmwareResource.java Co-authored-by: Vishesh <vishesh92@gmail.com>

Pearl1594 approved these changes Apr 15, 2024

View reviewed changes

DaanHoogland requested a review from vishesh92 April 15, 2024 18:14

sureshanaparti reviewed Apr 16, 2024

View reviewed changes

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java Outdated Show resolved Hide resolved

Update plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/…

57dd5f7

…vmware/resource/VmwareResource.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

vishesh92 approved these changes Apr 16, 2024

View reviewed changes

sureshanaparti reviewed Apr 16, 2024

View reviewed changes

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java Outdated Show resolved Hide resolved

sureshanaparti approved these changes Apr 16, 2024

View reviewed changes

Update plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/…

663b393

…vmware/resource/VmwareResource.java Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

DaanHoogland changed the base branch from 4.17 to 4.18 April 17, 2024 08:23

boring-cyborg bot added the component:virtual-router label Apr 17, 2024

rajujith approved these changes Apr 19, 2024

View reviewed changes

DaanHoogland merged commit 7affbb1 into apache:4.18 Apr 19, 2024

DaanHoogland deleted the ghi8747-nullPathProtection branch April 19, 2024 10:23

DaanHoogland mentioned this pull request Apr 19, 2024

ROOT volume got deleted in failure to migrate #8747

Closed

DaanHoogland added a commit that referenced this pull request Apr 19, 2024

Merge release branch 4.18 to 4.19

78e07cf

* 4.18: protect against null-path (#8915) UI: Fix missing locale strings for Status widget (#8792) Add a shutdownhook to remove jobs owned by the process (#8896)

DaanHoogland added a commit that referenced this pull request Apr 19, 2024

Merge release branch 4.19 to main

3cabe69

* 4.19: protect against null-path (#8915) UI: Fix missing locale strings for Status widget (#8792) Add a shutdownhook to remove jobs owned by the process (#8896)

DaanHoogland added this to the 4.19.1.0 milestone May 7, 2024

Conversation

DaanHoogland commented Apr 15, 2024 • edited by sureshanaparti Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

DaanHoogland commented Apr 15, 2024

Uh oh!

blueorangutan commented Apr 15, 2024

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Apr 15, 2024

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DaanHoogland commented Apr 15, 2024

Uh oh!

blueorangutan commented Apr 15, 2024

Uh oh!

blueorangutan commented Apr 15, 2024

Uh oh!

vishesh92 commented Apr 15, 2024

Uh oh!

blueorangutan commented Apr 15, 2024

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Apr 15, 2024

Uh oh!

Uh oh!

DaanHoogland commented Apr 16, 2024

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

DaanHoogland commented Apr 16, 2024

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

DaanHoogland commented Apr 16, 2024

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Apr 16, 2024

Uh oh!

DaanHoogland commented Apr 17, 2024

Uh oh!

blueorangutan commented Apr 17, 2024

Uh oh!

blueorangutan commented Apr 17, 2024

Uh oh!

DaanHoogland commented Apr 17, 2024

Uh oh!

blueorangutan commented Apr 17, 2024

Uh oh!

blueorangutan commented Apr 17, 2024

Uh oh!

DaanHoogland commented Apr 18, 2024

Uh oh!

DaanHoogland commented Apr 15, 2024 •

edited by sureshanaparti

Loading