Fix haproxy log rotation in VR system VM by vdombrovski · Pull Request #7587 · apache/cloudstack

vdombrovski · 2023-06-05T08:12:00Z

Description

This PR fixes #7576

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Change tested by modifiying the logrotation config directly on the SystemVM

DaanHoogland · 2023-06-05T10:55:01Z

@blueorangutan package

blueorangutan · 2023-06-05T10:56:03Z

@DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-06-05T11:54:37Z

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6082

DaanHoogland · 2023-06-05T13:31:23Z

@blueorangutan test

blueorangutan · 2023-06-05T13:32:03Z

@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

codecov · 2023-06-05T14:56:43Z

Codecov Report

Merging #7587 (e604d27) into 4.17 (ea2b537) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.17    #7587   +/-   ##
=========================================
  Coverage     10.38%   10.38%           
  Complexity     6648     6648           
=========================================
  Files          2453     2453           
  Lines        242467   242467           
  Branches      37943    37943           
=========================================
  Hits          25170    25170           
  Misses       214178   214178           
  Partials       3119     3119

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

weizhouapache

same command as #4869, it should be good.

weizhouapache · 2023-06-05T18:55:53Z

@vdombrovski
can you rebase with 4.17 branch, and re-target to 4.17 ?

blueorangutan · 2023-06-06T01:52:17Z

[SF] Trillian test result (tid-6677)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42977 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7587-t6677-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

vdombrovski · 2023-06-06T07:08:03Z

@vdombrovski can you rebase with 4.17 branch, and re-target to 4.17 ?

Done

weizhouapache · 2023-06-06T07:42:53Z

@vdombrovski can you rebase with 4.17 branch, and re-target to 4.17 ?

Done

thanks @vdombrovski

@blueorangutan package

blueorangutan · 2023-06-06T07:44:03Z

@weizhouapache a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-06-06T09:07:30Z

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6090

weizhouapache · 2023-06-06T10:16:27Z

@blueorangutan test

blueorangutan · 2023-06-06T10:18:03Z

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-06-06T22:06:07Z

[SF] Trillian test result (tid-6692)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41047 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7587-t6692-kvm-centos7.zip
Smoke tests completed. 98 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_deploy_vm_with_extraconfig_kvm	`Error`	1.16	test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm	`Error`	1.14	test_deploy_vm_extra_config_data.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	578.13	test_kubernetes_clusters.py
test_02_deploy_vm_on_specific_cluster	`Error`	1.14	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.17	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.15	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	0.12	test_vm_deployment_planner.py

weizhouapache · 2023-06-19T13:17:58Z

@blueorangutan package

blueorangutan · 2023-06-19T13:20:03Z

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-06-19T14:05:58Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6267

weizhouapache · 2023-06-19T14:29:08Z

@blueorangutan test

blueorangutan · 2023-06-19T14:30:03Z

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-06-20T01:24:31Z

[SF] Trillian test result (tid-6766)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37771 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7587-t6766-kvm-centos7.zip
Smoke tests completed. 99 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_deploy_vm_with_extraconfig_kvm	`Error`	1.14	test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm	`Error`	0.12	test_deploy_vm_extra_config_data.py
test_02_deploy_vm_on_specific_cluster	`Error`	0.12	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.14	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	1.16	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	1.14	test_vm_deployment_planner.py

DaanHoogland

clgtm

DaanHoogland · 2023-06-20T07:02:52Z

tested the config in a 4.18 system vm

weizhouapache · 2023-06-20T07:38:07Z

@vdombrovski
I did some testing but could not reproduce the issue.

I confirmed the old command does not work and verified the new command works.

root@r-13-VM:~# /bin/kill -HUP `cat /var/run/rsyslog.pid 2> /dev/null`

Usage:
 kill [options] <pid> [...]

Options:
 <pid> [...]            send signal to every <pid> listed
 -<signal>, -s, --signal <signal>
                        specify the <signal> to be sent
 -q, --queue <value>    integer value to be sent with the signal
 -l, --list=[<signal>]  list all signal names, or convert one to a name
 -L, --table            list all signal names in a nice table

 -h, --help     display this help and exit
 -V, --version  output version information and exit

For more details see kill(1).
root@r-13-VM:~# 
root@r-13-VM:~# ls /var/run/rsyslog.pid
ls: cannot access '/var/run/rsyslog.pid': No such file or directory


root@r-9061-VM:~# /usr/lib/rsyslog/rsyslog-rotate

since I have faced same issue before and fixed the issue by same command, I believe this should work.

boring-cyborg bot added the component:virtual-router label Jun 5, 2023

weizhouapache added this to the 4.18.1.0 milestone Jun 5, 2023

apache deleted a comment from blueorangutan Jun 5, 2023

weizhouapache approved these changes Jun 5, 2023

View reviewed changes

Fix haproxy log rotation in VR system VM

e604d27

vdombrovski changed the base branch from main to 4.17 June 6, 2023 07:07

boring-cyborg bot added component:agent component:build component:integration labels Jun 6, 2023

vdombrovski force-pushed the fix-vr-haproxy-logrotate branch from a21fe8f to e604d27 Compare June 6, 2023 07:07

vishesh92 mentioned this pull request Jun 7, 2023

Fix smoke tests for kubernetes cluster #7604

Closed

DaanHoogland closed this Jun 19, 2023

DaanHoogland reopened this Jun 19, 2023

DaanHoogland approved these changes Jun 20, 2023

View reviewed changes

weizhouapache merged commit 2222222 into apache:4.17 Jun 20, 2023

weizhouapache mentioned this pull request Jun 20, 2023

Logrotate issue in VirtualRouter #7576

Closed

vdombrovski deleted the fix-vr-haproxy-logrotate branch June 20, 2023 08:21

Conversation

vdombrovski commented Jun 5, 2023

Description

Types of changes

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

DaanHoogland commented Jun 5, 2023

Uh oh!

blueorangutan commented Jun 5, 2023

Uh oh!

blueorangutan commented Jun 5, 2023

Uh oh!

DaanHoogland commented Jun 5, 2023

Uh oh!

blueorangutan commented Jun 5, 2023

Uh oh!

codecov bot commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Jun 5, 2023

Uh oh!

blueorangutan commented Jun 6, 2023

Uh oh!

vdombrovski commented Jun 6, 2023

Uh oh!

weizhouapache commented Jun 6, 2023

Uh oh!

blueorangutan commented Jun 6, 2023

Uh oh!

blueorangutan commented Jun 6, 2023

Uh oh!

weizhouapache commented Jun 6, 2023

Uh oh!

blueorangutan commented Jun 6, 2023

Uh oh!

blueorangutan commented Jun 6, 2023

Uh oh!

weizhouapache commented Jun 19, 2023

Uh oh!

blueorangutan commented Jun 19, 2023

Uh oh!

blueorangutan commented Jun 19, 2023

Uh oh!

weizhouapache commented Jun 19, 2023

Uh oh!

blueorangutan commented Jun 19, 2023

Uh oh!

blueorangutan commented Jun 20, 2023

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jun 20, 2023

Uh oh!

weizhouapache commented Jun 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jun 5, 2023 •

edited

Loading