Skip to content

test: fix test_04_rvpc_network_garbage_collector_nics failure#11542

Merged
weizhouapache merged 2 commits intoapache:4.19from
weizhouapache:4.19-fix-test-caused-by-pr11518
Sep 2, 2025
Merged

test: fix test_04_rvpc_network_garbage_collector_nics failure#11542
weizhouapache merged 2 commits intoapache:4.19from
weizhouapache:4.19-fix-test-caused-by-pr11518

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Sep 1, 2025

Description

This PR fixes the test failure caused by PR #11518

e.g
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Sep 1, 2025
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 1, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 1, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.18%. Comparing base (d161dc7) to head (9a63b50).
⚠️ Report is 1 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #11542   +/-   ##
=========================================
  Coverage     15.18%   15.18%           
- Complexity    11368    11373    +5     
=========================================
  Files          5415     5415           
  Lines        476073   476073           
  Branches      58125    58125           
=========================================
+ Hits          72279    72307   +28     
+ Misses       395706   395675   -31     
- Partials       8088     8091    +3
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 1, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14797

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 1, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 1, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland
DaanHoogland reviewed Sep 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, but should other states be tested against as well?

(FAULT, BACKUP, …)

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 1, 2025

clgtm, but should other states be tested against as well?

(FAULT, BACKUP, …)

added a check on VR in BACKUP state too

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 1, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 1, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 1, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14807

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 1, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 1, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 1, 2025

[SF] Trillian test result (tid-14158)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 48549 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11542-t14158-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_create_iso_with_checksum_md5 Error 66.70 test_iso.py
test_01_secure_vm_migration Error 134.48 test_vm_life_cycle.py
test_01_secure_vm_migration Error 134.49 test_vm_life_cycle.py

@weizhouapache weizhouapache merged commit 48648d4 into apache:4.19 Sep 2, 2025
25 of 26 checks passed
@weizhouapache weizhouapache added this to the 4.19.4 milestone Sep 2, 2025
@DaanHoogland DaanHoogland deleted the 4.19-fix-test-caused-by-pr11518 branch September 2, 2025 06:20
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 2, 2025

[SF] Trillian test result (tid-14170)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49915 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11542-t14170-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_secured_to_nonsecured_vm_migration Error 394.11 test_vm_life_cycle.py

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
@weizhouapache @dhslove
test: fix test_04_rvpc_network_garbage_collector_nics failure (apache…
ed20cbf 
…#11542)

* test: fix test_04_rvpc_network_garbage_collector_nics failure

* test: check backup VR as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.19.4

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @blueorangutan @yadvr @DaanHoogland @sureshanaparti