Skip to content

VPC VR: return UNKNOWN redundant state if no guest nics#11518

Merged
harikrishna-patnala merged 2 commits intoapache:4.19from
weizhouapache:4.19-fix-vpc-vr-fault
Aug 29, 2025
Merged

VPC VR: return UNKNOWN redundant state if no guest nics#11518
harikrishna-patnala merged 2 commits intoapache:4.19from
weizhouapache:4.19-fix-vpc-vr-fault

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Aug 26, 2025

Description

This PR fixes #10677

steps to reproduce the issue

  • create a redundant VPC
  • create a vpc tier
  • create a vm but do not start it
  • check the VR redundant state after a while, both vpc VRs are FAULT state

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache linked an issue Aug 26, 2025 that may be closed by this pull request
listRouter provides "FAULT" redundantstate for VPC with no instance running #10677
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.18%. Comparing base (25f93b1) to head (866f2b8).
⚠️ Report is 2 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #11518   +/-   ##
=========================================
  Coverage     15.18%   15.18%           
  Complexity    11369    11369           
=========================================
  Files          5415     5415           
  Lines        476066   476066           
  Branches      58123    58123           
=========================================
+ Hits          72281    72284    +3     
+ Misses       395698   395697    -1     
+ Partials       8087     8085    -2
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, one remark though

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Aug 27, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 27, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 27, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14739

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Aug 27, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 27, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 28, 2025

[SF] Trillian test result (tid-14119)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56297 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11518-t14119-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_migrate_vm Error 47.25 test_vm_life_cycle.py
test_04_rvpc_network_garbage_collector_nics Failure 1449.21 test_vpc_redundant.py

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Aug 28, 2025

@blueorangutan test

@weizhouapache weizhouapache marked this pull request as ready for review August 28, 2025 08:29
@weizhouapache weizhouapache added this to the 4.19.4 milestone Aug 28, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 28, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 28, 2025

[SF] Trillian Build Failed (tid-14123)

harikrishna-patnala
harikrishna-patnala approved these changes Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Tested LGTM. VRs state is Unknown for both after a while too.

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Aug 29, 2025

thanks @harikrishna-patnala for the testing

I am wondering if the status should be UNKNOWN or BACKUP
what do you think ? @harikrishna-patnala @DaanHoogland

@harikrishna-patnala
Copy link
Copy Markdown
Member

harikrishna-patnala commented Aug 29, 2025

thanks @harikrishna-patnala for the testing

I am wondering if the status should be UNKNOWN or BACKUP what do you think ? @harikrishna-patnala @DaanHoogland

UNKNOWN seems to be fine @weizhouapache as it is really an unknown state right, both as BACKUP may not look good.

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Aug 29, 2025

UNKNOWN seems to be fine @weizhouapache as it is really an unknown state right, both as BACKUP may not look good.

correct, BACKUP state means there is another VR in PRIMARY state
let's keep UNKNOWN, thanks @harikrishna-patnala

@DaanHoogland
if no objection, let's merge ?

@harikrishna-patnala harikrishna-patnala merged commit 05e7a25 into apache:4.19 Aug 29, 2025
26 checks passed
@harikrishna-patnala harikrishna-patnala mentioned this pull request Aug 29, 2025
Closed
@DaanHoogland DaanHoogland deleted the 4.19-fix-vpc-vr-fault branch August 29, 2025 07:31
@weizhouapache weizhouapache mentioned this pull request Sep 1, 2025
Merged
14 tasks
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
@weizhouapache @dhslove
VPC VR: return UNKNOWN redundant state if no guest nics (apache#11518)
2160c6a 
* VPC VR: return UNKNOWN redundant state if no guest nics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

Assignees

No one assigned

Labels

component:networking component:virtual-router

Projects

None yet

Milestone

4.19.4

Development

Successfully merging this pull request may close these issues.

listRouter provides "FAULT" redundantstate for VPC with no instance running

4 participants

@weizhouapache @blueorangutan @harikrishna-patnala @DaanHoogland