Skip to content

ui: update project menu on projects change#11369

Merged
sureshanaparti merged 1 commit intoapache:4.19from
shapeblue:update-projectmenu-projectschange
Aug 1, 2025
Merged

ui: update project menu on projects change#11369
sureshanaparti merged 1 commit intoapache:4.19from
shapeblue:update-projectmenu-projectschange

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Aug 1, 2025 •
edited
Loading

Description

Fixes #11357

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

After change
https://github.com/user-attachments/assets/4cfc3032-46d7-411b-b6c5-97b1fb071d8b

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
ui: update project menu on projects change
12f1053 
Fixes apache#11357

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.17%. Comparing base (3850445) to head (12f1053).
⚠️ Report is 1 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #11369   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
+ Complexity    11365    11364    -1     
=========================================
  Files          5415     5415           
  Lines        476050   476055    +5     
  Branches      58119    58120    +1     
=========================================
+ Hits          72254    72259    +5     
  Misses       395710   395710           
  Partials       8086     8086
Flag Coverage Δ
uitests 4.28% <ø> (+<0.01%) ⬆️
unittests 15.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 1, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 1, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 1, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11369 (QA-JID-714)

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Aug 1, 2025 •
edited
Loading

@shwstppr your code looks good, but I have not seen the issue in qa (without the fix). Have you reproduced it?

AD: qa is still 4.20.0 and doesn’t have the regression yet.

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 1, 2025 •
edited
Loading

@DaanHoogland yes, though my env was 4.20 branch but I checked it had same code (4.19.3 onwards),

projects-update-before.mp4

DaanHoogland
DaanHoogland approved these changes Aug 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and code looks good

@sureshanaparti sureshanaparti added this to the 4.21.0 milestone Aug 1, 2025
@sureshanaparti sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Aug 1, 2025
@sureshanaparti sureshanaparti merged commit 1bfebd5 into apache:4.19 Aug 1, 2025
23 of 25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Aug 1, 2025
@sureshanaparti sureshanaparti mentioned this pull request Aug 1, 2025
Closed
@sureshanaparti sureshanaparti deleted the update-projectmenu-projectschange branch August 1, 2025 12:11
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
@shwstppr @dhslove
ui: update project menu on projects change (apache#11369)
59e2595 
Fixes apache#11357

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:UI type:regression

Projects

No open projects
Apache CloudStack 4.21.0
Status: Done

Milestone

4.21.0

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr @blueorangutan @DaanHoogland @yadvr @sureshanaparti