Skip to content

SG: Apply rules for both ipv4/ipv6 of VMs with associated account/SG#11243

Merged
DaanHoogland merged 1 commit intoapache:4.19from
weizhouapache:4.19-sg-rule-ipv6
Aug 29, 2025
Merged

SG: Apply rules for both ipv4/ipv6 of VMs with associated account/SG#11243
DaanHoogland merged 1 commit intoapache:4.19from
weizhouapache:4.19-sg-rule-ipv6

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Jul 18, 2025

Description

This PR fixes #7763

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache changed the base branch from main to 4.19 July 18, 2025 08:07
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jul 18, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 18, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.57%. Comparing base (06c80cd) to head (d848235).
⚠️ Report is 25 commits behind head on 4.19.

Files with missing lines Patch % Lines
...m/cloud/network/security/SecurityGroupVMMapVO.java 0.00% 3 Missing ⚠️
...oud/network/security/SecurityGroupManagerImpl.java 0.00% 3 Missing ⚠️
...ud/network/security/SecurityGroupManagerImpl2.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #11243      +/-   ##
============================================
+ Coverage     15.18%   16.57%   +1.39%     
- Complexity    11364    14058    +2694     
============================================
  Files          5415     5772     +357     
  Lines        475888   512945   +37057     
  Branches      58094    62306    +4212     
============================================
+ Hits          72256    85026   +12770     
- Misses       395546   418438   +22892     
- Partials       8086     9481    +1395
Flag Coverage Δ
uitests 3.89% <ø> (-0.39%) ⬇️
unittests 17.47% <0.00%> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 18, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14253

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jul 18, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 18, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 18, 2025

[SF] Trillian test result (tid-13819)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45356 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11243-t13819-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@sudo87
Copy link
Copy Markdown
Contributor

sudo87 commented Aug 28, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 28, 2025

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 28, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14748

@weizhouapache weizhouapache marked this pull request as ready for review August 28, 2025 08:30
sureshanaparti
sureshanaparti approved these changes Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

harikrishna-patnala
harikrishna-patnala approved these changes Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@sudo87
Copy link
Copy Markdown
Contributor

sudo87 commented Aug 29, 2025

lgtm tested the ipv6 between 2 vms with the fix

@DaanHoogland DaanHoogland merged commit ba7ec88 into apache:4.19 Aug 29, 2025
23 of 44 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-sg-rule-ipv6 branch August 29, 2025 09:39
@weizhouapache weizhouapache added this to the 4.19.4 milestone Aug 29, 2025
@weizhouapache weizhouapache mentioned this pull request Aug 29, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
@weizhouapache @dhslove
SG: Apply rules for both ipv4/ipv6 of VMs with associated account/SG (a…
655b065 
…pache#11243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

component:networking component:security-group

Projects

None yet

Milestone

4.19.4

Development

Successfully merging this pull request may close these issues.

Account level ingress rules do not work with ipv6

6 participants

@weizhouapache @blueorangutan @sudo87 @harikrishna-patnala @sureshanaparti @DaanHoogland