Skip to content

[UI] Add dedicated account field dropdown on zone creation#11195

Merged
sureshanaparti merged 1 commit intoapache:4.20from
shapeblue:420-zone-wizard-account
Jul 26, 2025
Merged

[UI] Add dedicated account field dropdown on zone creation#11195
sureshanaparti merged 1 commit intoapache:4.20from
shapeblue:420-zone-wizard-account

Conversation

@nvazquez
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez commented Jul 14, 2025

Description

This PR adds the account selection dropdown to the dedicated account field on zone creation

Screenshot 2025-07-14 at 11 07 22

Fixes: #10919

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@nvazquez nvazquez added this to the 4.20.2 milestone Jul 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.15%. Comparing base (61e74e0) to head (8dfc126).
⚠️ Report is 26 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #11195   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13273    13274    +1     
=========================================
  Files          5656     5656           
  Lines        497728   497732    +4     
  Branches      60360    60361    +1     
=========================================
+ Hits          80420    80421    +1     
- Misses       408357   408360    +3     
  Partials       8951     8951
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 17.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Jul 14, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 14, 2025

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 14, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11195 (QA-JID-664)

DaanHoogland
DaanHoogland approved these changes Jul 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, tested in qa

@nvazquez nvazquez linked an issue Jul 16, 2025 that may be closed by this pull request
UI: No account selection in the zone creation wizard #10919
Closed
Pearl1594
Pearl1594 approved these changes Jul 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jul 26, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 26, 2025

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 26, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11195 (QA-JID-689)

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jul 26, 2025

Verified in qa simulator env.

@sureshanaparti sureshanaparti merged commit 40035f5 into apache:4.20 Jul 26, 2025
23 of 25 checks passed
@sureshanaparti sureshanaparti mentioned this pull request Jul 26, 2025
Closed
@DaanHoogland DaanHoogland deleted the 420-zone-wizard-account branch July 26, 2025 09:14
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
@nvazquez @dhslove
[UI] Add dedicated account field dropdown on zone creation (apache#11195
ead22f9 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

UI: No account selection in the zone creation wizard

5 participants

@nvazquez @blueorangutan @sureshanaparti @DaanHoogland @Pearl1594