Skip to content

Improve error when a template to owned by non root-admin is registered for all zones.#11170

Merged
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:template-all-zones
Jul 10, 2025
Merged

Improve error when a template to owned by non root-admin is registered for all zones.#11170
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:template-all-zones

Conversation

@abh1sar
Copy link
Copy Markdown
Contributor

@abh1sar abh1sar commented Jul 9, 2025

Description

This PR fixes #10945

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot 2025-07-09 at 5 41 40 PM

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@abh1sar abh1sar added this to the 4.21.0 milestone Jul 9, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 16.57%. Comparing base (0d5a0ea) to head (88e09a1).
Report is 6 commits behind head on 4.19.

Files with missing lines Patch % Lines
...n/java/com/cloud/template/TemplateAdapterBase.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #11170      +/-   ##
============================================
+ Coverage     15.18%   16.57%   +1.39%     
- Complexity    11365    13987    +2622     
============================================
  Files          5416     5745     +329     
  Lines        475890   510847   +34957     
  Branches      58093    62140    +4047     
============================================
+ Hits          72254    84695   +12441     
- Misses       395550   416677   +21127     
- Partials       8086     9475    +1389
Flag Coverage Δ
uitests 3.91% <ø> (-0.38%) ⬇️
unittests 17.47% <0.00%> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bernardodemarco
bernardodemarco approved these changes Jul 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@abh1sar, I believe that the PR could target the 4.20 branch, what do you think?

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 9, 2025

clgtm

@abh1sar, I believe that the PR could target the 4.20 branch, what do you think?

I agree, the issue is also marked for the 4.20 branch. Worth looking if even it is applicable on 4.19.

@abh1sar abh1sar changed the base branch from main to 4.19 July 9, 2025 12:44
@abh1sar abh1sar changed the base branch from 4.19 to main July 9, 2025 12:45
@abh1sar abh1sar force-pushed the template-all-zones branch from e73a8a2 to 88e09a1 Compare July 9, 2025 12:53
@abh1sar abh1sar changed the base branch from main to 4.19 July 9, 2025 12:54
@abh1sar
Copy link
Copy Markdown
Contributor Author

abh1sar commented Jul 9, 2025

Thanks @bernardodemarco and @DaanHoogland.
I checked that the issue is applicable to 4.19 also. targeting 4.19.

DaanHoogland
DaanHoogland approved these changes Jul 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

weizhouapache
weizhouapache approved these changes Jul 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 10, 2025

textual change only, merging.

@DaanHoogland DaanHoogland merged commit 7715b3d into apache:4.19 Jul 10, 2025
25 of 26 checks passed
@DaanHoogland DaanHoogland deleted the template-all-zones branch July 10, 2025 07:39
@DaanHoogland DaanHoogland mentioned this pull request Jul 10, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 16, 2025
@abh1sar @dhslove
Improve the error throws when a template to owned by a non root-admin…
522836c 
… is registered for all zones. (apache#11170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@bernardodemarco bernardodemarco bernardodemarco approved these changes

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

Assignees

No one assigned

Labels

component:agent component:integration

Projects

No open projects
Apache CloudStack 4.21.0
Status: Done

Milestone

4.21.0

Development

Successfully merging this pull request may close these issues.

better error handling on register template when domain and zone=-1 are called

5 participants

@abh1sar @DaanHoogland @weizhouapache @bernardodemarco @sureshanaparti