[CKS] Create Kubernetes ISO support for ARCH optional parameter by nvazquez · Pull Request #10986 · apache/cloudstack

nvazquez · 2025-06-06T20:10:33Z

Description

CloudStack supports Multi-Arch zones #9619 since 4.20.

This PR introduces an optional parameter ARCH for the create-kubernetes-binaries-iso.sh script to include the corresponding arch binaries. Also, the generated ISO will include the ARCH on its name

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested three scenarios:

Not passing the ARCH pameter -> observe the script downloads amd64 binaries on the ISO
Passing ARCH=arm64 -> observe the script downloads arm64 binaries on the ISO
Passing ARCH=aaarm -> ERROR

How did you try to break this feature and the system with this change?

codecov · 2025-06-06T20:23:05Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.57%. Comparing base (b57994e) to head (441cfc4).
⚠️ Report is 142 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10986      +/-   ##
============================================
- Coverage     16.57%   16.57%   -0.01%     
  Complexity    14059    14059              
============================================
  Files          5772     5772              
  Lines        512938   512938              
  Branches      62304    62304              
============================================
- Hits          85026    85024       -2     
- Misses       418431   418432       +1     
- Partials       9481     9482       +1

Flag	Coverage Δ
uitests	`3.89% <ø> (ø)`
unittests	`17.47% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shwstppr

changes looks good. One minor comment

shwstppr · 2025-06-09T04:30:44Z

scripts/util/create-kubernetes-binaries-iso.sh

+if [ -n "${8}" ]; then
+  ARCH="${8}"
+  if [ "$ARCH" != "amd64" ] && [ "$ARCH" != "arm64" ]; then
+    echo "ERROR: ARCH must be 'amd64' or 'arm64'. If the optional parameter ARCH is not set then 'amd64' is used."


In Java code/UI we've used aarch64, should that also translate to arm64 for consistency

Thanks @shwstppr - fixed

For sake of simplicity, check what arch type k8s uses in its urls (it that arm64 or aarch64) ? So the script can still take in aarch64 as input, but produce the output with arch-name as used by k8s urls.

yadvr · 2025-06-10T08:17:39Z

@blueorangutan package

blueorangutan · 2025-06-10T08:18:04Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache · 2025-06-10T09:14:29Z

To be consistent to the systemvm template and packages, I think it would be better to use the following in the ISO name

x86_64
aarch64

refer to https://download.cloudstack.org/systemvm/4.20/
and https://download.cloudstack.org/el/9/4.20/

yes, I know some other projects use amd64/arm64

blueorangutan · 2025-06-10T09:45:58Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13684

nvazquez · 2025-06-10T11:23:05Z

Thanks @weizhouapache I have fixed the ISO naming

@blueorangutan package

blueorangutan · 2025-06-10T11:24:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

scripts/util/create-kubernetes-binaries-iso.sh

blueorangutan · 2025-06-10T12:32:25Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13692

Co-authored-by: Wei Zhou <weizhou@apache.org>

github-actions · 2025-06-19T07:57:59Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sureshanaparti · 2025-07-14T11:30:25Z

@nvazquez can you resolve the conflicts.

sureshanaparti

clgtm

nvazquez · 2025-07-16T22:50:39Z

Thanks @sureshanaparti - conflicts fixed

nvazquez · 2025-07-16T23:29:54Z

@blueorangutan package

blueorangutan · 2025-07-16T23:32:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-17T00:42:48Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14219

sureshanaparti · 2025-07-23T18:07:27Z

@blueorangutan package

blueorangutan · 2025-07-23T18:08:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-23T20:05:12Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14321

sureshanaparti · 2025-07-24T04:02:45Z

@blueorangutan test

blueorangutan · 2025-07-24T04:04:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-07-24T22:22:19Z

[SF] Trillian test result (tid-13869)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 62359 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10986-t13869-kvm-ol8.zip
Smoke tests completed. 142 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

…he#10986) * [CKS] Create Kubernetes ISO support for ARCH optional parameter * Include arch on the build name * Refactor * Fix ISO naming * Apply suggestions from code review Co-authored-by: Wei Zhou <weizhou@apache.org> * Reorder parameters --------- Co-authored-by: Wei Zhou <weizhou@apache.org>

[CKS] Create Kubernetes ISO support for ARCH optional parameter

d8d4f82

nvazquez added this to the 4.21.0 milestone Jun 6, 2025

nvazquez requested review from Pearl1594, kiranchavala, shwstppr, vishesh92 and yadvr June 6, 2025 20:10

nvazquez added component:kubernetes component:cks labels Jun 6, 2025

Include arch on the build name

e2beb9b

shwstppr reviewed Jun 9, 2025

View reviewed changes

Refactor

2332092

yadvr approved these changes Jun 10, 2025

View reviewed changes

Pearl1594 approved these changes Jun 10, 2025

View reviewed changes

Fix ISO naming

68115b5

weizhouapache reviewed Jun 10, 2025

View reviewed changes

scripts/util/create-kubernetes-binaries-iso.sh Outdated Show resolved Hide resolved

scripts/util/create-kubernetes-binaries-iso.sh Outdated Show resolved Hide resolved

Apply suggestions from code review

ced724e

Co-authored-by: Wei Zhou <weizhou@apache.org>

github-actions bot added the status:has-conflicts label Jun 19, 2025

sureshanaparti approved these changes Jul 14, 2025

View reviewed changes

sureshanaparti added the status:needs-testing label Jul 14, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jul 14, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jul 14, 2025

Merge branch 'main' into 421-cks-iso-script-arch

d538db7

github-actions bot removed the status:has-conflicts label Jul 16, 2025

Reorder parameters

441cfc4

nvazquez merged commit 13892e2 into apache:main Jul 25, 2025
25 of 26 checks passed

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jul 25, 2025

nvazquez deleted the 421-cks-iso-script-arch branch July 25, 2025 19:45

sureshanaparti removed the status:needs-testing label Jul 26, 2025

sureshanaparti added the type:improvement label Aug 8, 2025

Conversation

nvazquez commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

nvazquez Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

yadvr Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jun 10, 2025

Uh oh!

blueorangutan commented Jun 10, 2025

Uh oh!

weizhouapache commented Jun 10, 2025

Uh oh!

blueorangutan commented Jun 10, 2025

Uh oh!

nvazquez commented Jun 10, 2025

Uh oh!

blueorangutan commented Jun 10, 2025

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented Jun 10, 2025

Uh oh!

github-actions bot commented Jun 19, 2025

Uh oh!

sureshanaparti commented Jul 14, 2025

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Jul 16, 2025

Uh oh!

nvazquez commented Jul 16, 2025

Uh oh!

blueorangutan commented Jul 16, 2025

Uh oh!

blueorangutan commented Jul 17, 2025

Uh oh!

sureshanaparti commented Jul 23, 2025

Uh oh!

blueorangutan commented Jul 23, 2025

Uh oh!

blueorangutan commented Jul 23, 2025

Uh oh!

sureshanaparti commented Jul 24, 2025

Uh oh!

blueorangutan commented Jul 24, 2025

Uh oh!

blueorangutan commented Jul 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nvazquez commented Jun 6, 2025 •

edited

Loading

codecov bot commented Jun 6, 2025 •

edited

Loading