New Feature: Multi-arch Zones by nvazquez · Pull Request #9619 · apache/cloudstack

nvazquez · 2024-08-31T19:54:09Z

Description

This PR introduces the multi-arch zones, allowing users to select the VM arch upon deployment.

Multi-arch zone support in CloudStack can allow admins to mix x86_64 & arm64 hosts within the same zone with the following changes proposed:

All hosts in a clusters need to be homogenous, wrt host CPU type (amd64 vs arm64) and hypevisor
Arch-aware templates & ISOs:
- Add support for a new arch field (default set of: amd64 and arm64), when unspecified defaults to amd64 and for existing templates & iso
- Allow admins to edit the arch type of the registered template & iso
Arch-aware clusters and host:
- Add new attribute field for cluster and hosts (kvm host agents can automatically report this, arch of the first host of the cluster is cluster's architecture), defaults to amd64 when not specified
- Allow admins to edit the arch of an existing cluster
VM deployment form (UI):
- In a multi-arch zone/env, the VM deployment form can allow some kind of template/iso filtration in the UI
- Users should be able to select arch: amd64 & arm64; but this is shown only in a multi-arch zone (env)
VM orchestration and lifecycle operations:
- Use of VM/template's arch to correctly decide where to provision the VM (on the correct strictly arch-matching host/clusters) & other lifecycle operations (such as migration from/to arch-matching hosts)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

nvazquez · 2024-08-31T20:01:29Z

@blueorangutan package

blueorangutan · 2024-08-31T20:02:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-08-31T20:07:46Z

Codecov Report

Attention: Patch coverage is 15.05376% with 237 lines in your changes missing coverage. Please review.

Project coverage is 15.76%. Comparing base (679ce1a) to head (daec7bc).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
api/src/main/java/com/cloud/cpu/CPU.java	40.00%	15 Missing ⚠️
...n/java/com/cloud/resource/ResourceManagerImpl.java	0.00%	14 Missing ⚠️
agent/src/main/java/com/cloud/agent/Agent.java	0.00%	13 Missing ⚠️
...src/main/java/com/cloud/dc/dao/ClusterDaoImpl.java	40.00%	12 Missing ⚠️
...java/com/cloud/agent/manager/AgentManagerImpl.java	0.00%	10 Missing ⚠️
...n/java/com/cloud/template/TemplateAdapterBase.java	0.00%	9 Missing ⚠️
...a/org/apache/cloudstack/util/CPUArchConverter.java	0.00%	7 Missing ⚠️
.../cloud/storage/upload/params/UploadParamsBase.java	0.00%	7 Missing ⚠️
...pache/cloudstack/api/response/ClusterResponse.java	0.00%	6 Missing ⚠️
...g/apache/cloudstack/api/response/HostResponse.java	0.00%	6 Missing ⚠️
... and 35 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9619      +/-   ##
============================================
- Coverage     15.76%   15.76%   -0.01%     
- Complexity    12507    12510       +3     
============================================
  Files          5619     5621       +2     
  Lines        491158   491471     +313     
  Branches      62973    60171    -2802     
============================================
+ Hits          77419    77460      +41     
- Misses       405283   405555     +272     
  Partials       8456     8456

Flag	Coverage Δ
uitests	`4.04% <ø> (-0.01%)`	⬇️
unittests	`16.57% <15.05%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-08-31T21:03:30Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10893

nvazquez · 2024-08-31T22:13:02Z

@blueorangutan ui

DaanHoogland · 2024-09-05T13:22:14Z

@blueorangutan package

blueorangutan · 2024-09-05T13:24:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-05T15:20:58Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11012

yadvr · 2024-09-05T16:50:36Z

Minor conflict (no need for repackaging though), pl address @nvazquez

@blueorangutan test

blueorangutan · 2024-09-05T16:52:04Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

github-actions · 2024-09-05T17:10:48Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

yadvr · 2024-09-05T17:13:24Z

cc @nvazquez hope I haven't screwed up 🤞 the merge conflict

@blueorangutan package

blueorangutan · 2024-09-05T17:14:03Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-05T18:19:57Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11016

yadvr · 2024-09-05T18:28:58Z

@blueorangutan test

blueorangutan · 2024-09-05T18:30:05Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

yadvr · 2024-09-06T05:26:17Z

@blueorangutan package

blueorangutan · 2024-09-06T05:28:05Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-06T06:34:12Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11024

kiranchavala

LGTM,

Tested the feature

Able to register/update the template, iso, kubernetes iso based on architecture.

The architecture details of the template,iso are mentioned in the UI

Able to update the cluster based on the architecture

blueorangutan · 2024-09-06T10:55:56Z

[SF] Trillian test result (tid-11386)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55615 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9619-t11386-kvm-ol8.zip
Smoke tests completed. 137 look OK, 1 have errors, 2 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_mount_shared_fs	`Failure`	93.24	test_sharedfs_lifecycle.py
test_resize_shared_fs	`Error`	0.23	test_sharedfs_lifecycle.py
all_test_network	`Skipped`	---	test_network.py
all_test_nic_adapter_type	`Skipped`	---	test_nic_adapter_type.py

This introduces the multi-arch zones, allowing users to select the VM arch upon deployment. Multi-arch zone support in CloudStack can allow admins to mix x86_64 & arm64 hosts within the same zone with the following changes proposed: - All hosts in a clusters need to be homogenous, wrt host CPU type (amd64 vs arm64) and hypevisor - Arch-aware templates & ISOs: - Add support for a new arch field (default set of: amd64 and arm64), when unspecified defaults to amd64 and for existing templates & iso - Allow admins to edit the arch type of the registered template & iso - Arch-aware clusters and host: - Add new attribute field for cluster and hosts (kvm host agents can automatically report this, arch of the first host of the cluster is cluster's architecture), defaults to amd64 when not specified - Allow admins to edit the arch of an existing cluster - VM deployment form (UI): - In a multi-arch zone/env, the VM deployment form can allow some kind of template/iso filtration in the UI - Users should be able to select arch: amd64 & arm64; but this is shown only in a multi-arch zone (env) - VM orchestration and lifecycle operations: - Use of VM/template's arch to correctly decide where to provision the VM (on the correct strictly arch-matching host/clusters) & other lifecycle operations (such as migration from/to arch-matching hosts) Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>

nvazquez added 11 commits July 24, 2024 12:32

Add arch field to clusters

7e97e68

Add arch to hosts

48ecbb6

Retrieve arch from KVM host and send on StartupRoutingCommand

139759e

Merge branch 'main' into 420-multiarch

5fc1363

Merge branch 'main' into 420-multiarch

f4c6ba8

Add architecture to templates

c8d046b

Minor fixes

866c172

Update template and iso

6dc666d

Update clusters

aca01bd

Multi arch zone response and list templates and isos by arch

3fdd715

Enhance Deploy VM wizard

2eab9cb

nvazquez added type:new-feature component:templates labels Aug 31, 2024

nvazquez added this to the 4.20.0.0 milestone Aug 31, 2024

nvazquez requested review from DaanHoogland, Pearl1594, harikrishna-patnala, kiranchavala, shwstppr, weizhouapache and yadvr August 31, 2024 19:54

boring-cyborg bot added component:api component:orchestration component:storage labels Aug 31, 2024

Fix default values from DB

d70a977

nvazquez added 2 commits September 5, 2024 10:14

Fix DB converter by using a class instead of enum

8467a57

Merge branch 'main' into 420-multiarch

6369258

github-actions bot removed the status:has-conflicts label Sep 5, 2024

github-actions bot added the status:has-conflicts label Sep 5, 2024

Merge branch 'main' into 420-multiarch

b604f89

github-actions bot removed the status:has-conflicts label Sep 5, 2024

apache deleted a comment from blueorangutan Sep 5, 2024

Merge branch 'main' into 420-multiarch

daec7bc

kiranchavala approved these changes Sep 6, 2024

View reviewed changes

yadvr merged commit 8c8d115 into apache:main Sep 6, 2024

yadvr deleted the 420-multiarch branch September 6, 2024 06:44

nvazquez mentioned this pull request Sep 27, 2024

Multi-Arch zones documentation apache/cloudstack-documentation#440

Merged

yadvr assigned nvazquez Mar 17, 2025

nvazquez mentioned this pull request Jun 6, 2025

[CKS] Create Kubernetes ISO support for ARCH optional parameter #10986

Merged

14 tasks

Conversation

nvazquez commented Aug 31, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

nvazquez commented Aug 31, 2024

Uh oh!

blueorangutan commented Aug 31, 2024

Uh oh!

codecov bot commented Aug 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Aug 31, 2024

Uh oh!

nvazquez commented Aug 31, 2024

Uh oh!

DaanHoogland commented Sep 5, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

yadvr commented Sep 5, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

github-actions bot commented Sep 5, 2024

Uh oh!

yadvr commented Sep 5, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

yadvr commented Sep 5, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

yadvr commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Sep 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Aug 31, 2024 •

edited

Loading