Conversation
|
@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10357 +/- ##
=========================================
Coverage 15.15% 15.15%
- Complexity 11317 11318 +1
=========================================
Files 5410 5410
Lines 474793 474778 -15
Branches 57928 57928
=========================================
+ Hits 71955 71956 +1
+ Misses 394789 394773 -16
Partials 8049 8049
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, looks good in qa as well
harikrishna-patnala
left a comment
There was a problem hiding this comment.
@vishesh92 do we need it here too ?
missed that. let me add. |
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Description
This PR fixes the missing buttons in the UI. This bug was introduced in #10243
Generated Summary
This pull request includes several changes to simplify the codebase by removing unnecessary braces in arrow functions across multiple configuration files. The changes ensure a more concise and consistent code style.
Codebase simplification:
ui/src/config/section/compute.js: Removed unnecessary braces in theshowmethod for multiple components, includingDeployVM,CreateKubernetesCluster,CreateAutoScaleVmGroup, andCreateInstanceGroup. [1] [2] [3] [4]ui/src/config/section/image.js: Simplified theshowmethod by removing unnecessary braces for components such asRegisterOrUploadTemplate,RegisterOrUploadIso, andAddKubernetesSupportedVersion. [1] [2] [3]ui/src/config/section/network.js: Updated theshowmethod to remove unnecessary braces for components includingCreateVpc,DeployVnfAppliance,AddVpnGateway,AddVpnUser, andCreateVpnCustomerGateway. [1] [2] [3] [4] [5]ui/src/config/section/storage.js: Simplified theshowmethod by removing unnecessary braces forCreateVolumeandUploadVolumecomponents. [1] [2]Fixes: #10356
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?