Hide register template, create/upload volume and create vpc buttons when zone is not created. by abh1sar · Pull Request #10243 · apache/cloudstack

abh1sar · 2025-01-22T19:48:51Z

Description

This PR fixes #8145

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…ton if zone is not created.

abh1sar · 2025-01-22T19:49:19Z

@blueorangutan ui

blueorangutan · 2025-01-22T19:50:04Z

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov · 2025-01-22T19:57:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.16%. Comparing base (0d5047b) to head (b786f42).
Report is 6 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10243   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11300    11301    +1     
=========================================
  Files          5408     5409    +1     
  Lines        473912   473927   +15     
  Branches      57844    57844           
=========================================
+ Hits          71855    71864    +9     
- Misses       394025   394031    +6     
  Partials       8032     8032

Flag	Coverage Δ
uitests	`4.29% <ø> (-0.01%)`	⬇️
unittests	`15.88% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abh1sar · 2025-01-22T20:09:02Z

@blueorangutan package

blueorangutan · 2025-01-22T20:10:03Z

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-01-22T21:05:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12178

DaanHoogland · 2025-01-23T08:18:39Z

@abh1sar , I think the solution should not be UI only. The API as well should fail at service level, agree?

Edit: not that this would not be an improvement.

abh1sar · 2025-01-24T10:53:04Z

@abh1sar , I think the solution should not be UI only. The API as well should fail at service level, agree?

Edit: not that this would not be an improvement.

@DaanHoogland the 'zone' parameter is required for the api, so the api returns an error if zone is not specified.

DaanHoogland · 2025-01-24T12:04:39Z

@DaanHoogland the 'zone' parameter is required for the api, so the api returns an error if zone is not specified.

yes, you are right. 👍

DaanHoogland

clgtm

DaanHoogland · 2025-01-24T12:05:19Z

@blueorangutan ui

blueorangutan · 2025-01-24T12:06:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-01-24T12:22:57Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10243 (QA-JID-532)

borisstoyanov

Maybe we can also add:
Images:

ISOs - register/upload iso
Kubernetes - Add kub version
Network:
VNF Appliance - add VNF appliance
s2s VPN - Add VPN GW
VPN Users - Add User
VPN Cust Gateway - Add
Storage:
Buckets - create
Compute
Add instance
Kubernetes - create kub cluster
autoscale IG - New autoscale IG
Instance group - new IG

abh1sar · 2025-01-31T10:13:39Z

@blueorangutan ui

blueorangutan · 2025-01-31T10:15:04Z

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

abh1sar · 2025-01-31T10:18:54Z

@borisstoyanov @DaanHoogland
I have made the suggested changes with the exception of create bucket. I was able to configure object storage and create bucket without creating a zone. Please check.

blueorangutan · 2025-01-31T10:32:12Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10243 (QA-JID-540)

DaanHoogland

code looks good, but a bit boilerplate @abh1sar . Would it be possible to create an isAZoneCreated() method and call that for clarity?

abh1sar · 2025-02-02T13:44:21Z

@blueorangutan ui

blueorangutan · 2025-02-02T13:45:04Z

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-02-02T14:01:23Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10243 (QA-JID-541)

borisstoyanov

How about these remaining @abh1sar:

Images:
ISOs - register/upload iso
Kubernetes - Add kub version
Network:
VNF Appliance - add VNF appliance
s2s VPN - Add VPN GW
VPN Users - Add User
VPN Cust Gateway - Add
Compute
Add instance
Kubernetes - create kub cluster
autoscale IG - New autoscale IG
Instance group - new IG

borisstoyanov · 2025-02-04T09:40:34Z

@blueorangutan package

blueorangutan · 2025-02-04T09:42:04Z

@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

borisstoyanov · 2025-02-04T09:44:19Z

just noticed it hasn't been built in a while.

blueorangutan · 2025-02-04T10:48:49Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12325

DaanHoogland · 2025-02-04T11:20:03Z

How about these remaining @abh1sar:

* Images:
  ISOs - register/upload iso
  Kubernetes - Add kub version

* Network:
  VNF Appliance - add VNF appliance
  s2s VPN - Add VPN GW
  VPN Users - Add User
  VPN Cust Gateway - Add

* Compute
  Add instance
  Kubernetes - create kub cluster
  autoscale IG - New autoscale IG
  Instance group - new IG

according to the code, these have been addressed, @borisstoyanov .

borisstoyanov

OK LGTM, manually checked

…hen zone is not created. (apache#10243)

Don't show register template, create/upload volume and create vpc but…

09994a4

…ton if zone is not created.

boring-cyborg bot added the component:UI label Jan 22, 2025

abh1sar requested a review from DaanHoogland January 22, 2025 19:49

DaanHoogland linked an issue Jan 23, 2025 that may be closed by this pull request

As a user I can start registring templates before a zone is created #8145

Closed

DaanHoogland added this to the 4.19.2 milestone Jan 23, 2025

DaanHoogland changed the title ~~Hide register template, create/upload volume and create vpc buttons wheen zone is not created.~~ Hide register template, create/upload volume and create vpc buttons when zone is not created. Jan 24, 2025

DaanHoogland approved these changes Jan 24, 2025

View reviewed changes

DaanHoogland added the status:needs-testing label Jan 24, 2025

borisstoyanov self-assigned this Jan 27, 2025

borisstoyanov requested changes Jan 27, 2025

View reviewed changes

abh1sar added 3 commits January 29, 2025 00:47

Hide buttons in compute, network and storage if zone is not created

f8e9fd2

reverting change to createBucket button.

4852667

disable deployvm button if zone is not created

5376f87

abh1sar requested review from DaanHoogland and borisstoyanov January 31, 2025 10:19

DaanHoogland reviewed Jan 31, 2025

View reviewed changes

Abstract condition into isZoneCreated method

33c7722

Merge branch '4.19' into no-zone

b786f42

borisstoyanov requested changes Feb 4, 2025

View reviewed changes

borisstoyanov approved these changes Feb 4, 2025

View reviewed changes

borisstoyanov removed the status:needs-testing label Feb 4, 2025

DaanHoogland merged commit 1b2f6c9 into apache:4.19 Feb 4, 2025

DaanHoogland deleted the no-zone branch February 4, 2025 11:33

vishesh92 mentioned this pull request Feb 10, 2025

UI: Fixup missing buttons #10357

Merged

14 tasks

DaanHoogland mentioned this pull request Feb 13, 2025

As a user I can start registring templates before a zone is created #8145

Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025

Hide register template, create/upload volume and create vpc buttons w…

39b388d

…hen zone is not created. (apache#10243)

Conversation

abh1sar commented Jan 22, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

abh1sar commented Jan 22, 2025

Uh oh!

blueorangutan commented Jan 22, 2025

Uh oh!

codecov bot commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

abh1sar commented Jan 22, 2025

Uh oh!

blueorangutan commented Jan 22, 2025

Uh oh!

blueorangutan commented Jan 22, 2025

Uh oh!

DaanHoogland commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abh1sar commented Jan 24, 2025

Uh oh!

DaanHoogland commented Jan 24, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jan 24, 2025

Uh oh!

blueorangutan commented Jan 24, 2025

Uh oh!

blueorangutan commented Jan 24, 2025

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

abh1sar commented Jan 31, 2025

Uh oh!

blueorangutan commented Jan 31, 2025

Uh oh!

abh1sar commented Jan 31, 2025

Uh oh!

blueorangutan commented Jan 31, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

abh1sar commented Feb 2, 2025

Uh oh!

blueorangutan commented Feb 2, 2025

Uh oh!

blueorangutan commented Feb 2, 2025

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

borisstoyanov commented Feb 4, 2025

Uh oh!

blueorangutan commented Feb 4, 2025

Uh oh!

borisstoyanov commented Feb 4, 2025

Uh oh!

blueorangutan commented Feb 4, 2025

Uh oh!

DaanHoogland commented Feb 4, 2025

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

codecov bot commented Jan 22, 2025 •

edited

Loading

DaanHoogland commented Jan 23, 2025 •

edited

Loading