[BEAM-3066] Make the main seed job standalone#4019
Merged
asfgit merged 1 commit intoapache:masterfrom Oct 23, 2017
Merged
Conversation
987eb53 to
0a9f0fd
Compare
6 tasks
Contributor
|
LGTM |
0a9f0fd to
073601b
Compare
asfgit
pushed a commit
that referenced
this pull request
Oct 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.R: @jasonkuster
This is a follow-up to #4004. That PR added a standalone seed job that would continue to work even if I screwed up the main seed job. But if I understand correctly, the "standalone seed job" does not have permissions to create new jobs. I didn't realize this at the time, but either way my plan would be mostly unchanged. The standalone job did succeed, so it has the power to restore existing jobs if not to create new ones.
This switches the main seed job to have the same contents, leaving the standalone job as a backup so we can restore easily.
The end goal is this: we "never" touch the seed job again, and no tweaking of other jobs can affect it. Then we can start to improve them safely.