Skip to content

[BEAM-3066] Make the main seed job standalone#4019

Merged
asfgit merged 1 commit intoapache:masterfrom
kennknowles:seed-job-swap
Oct 23, 2017
Merged

[BEAM-3066] Make the main seed job standalone#4019
asfgit merged 1 commit intoapache:masterfrom
kennknowles:seed-job-swap

Conversation

@kennknowles
Copy link
Copy Markdown
Member

@kennknowles kennknowles commented Oct 19, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @jasonkuster

This is a follow-up to #4004. That PR added a standalone seed job that would continue to work even if I screwed up the main seed job. But if I understand correctly, the "standalone seed job" does not have permissions to create new jobs. I didn't realize this at the time, but either way my plan would be mostly unchanged. The standalone job did succeed, so it has the power to restore existing jobs if not to create new ones.

This switches the main seed job to have the same contents, leaving the standalone job as a backup so we can restore easily.

The end goal is this: we "never" touch the seed job again, and no tweaking of other jobs can affect it. Then we can start to improve them safely.

@chamikaramj
Copy link
Copy Markdown
Contributor

LGTM

@asfgit asfgit merged commit 073601b into apache:master Oct 23, 2017
asfgit pushed a commit that referenced this pull request Oct 23, 2017
@kennknowles kennknowles deleted the seed-job-swap branch October 23, 2017 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants