[BEAM-3066] Add standalone version of seed job#4004
Merged
asfgit merged 1 commit intoapache:masterfrom Oct 19, 2017
Merged
Conversation
Member
Author
|
Diff of seed job versus this new standalone job: // Defines the seed job, which creates or updates all other Jenkins projects.
-job('beam_SeedJob') {
+job('beam_SeedJob_Standalone') {
description('Automatically configures all Apache Beam Jenkins projects based' +
' on Jenkins DSL groovy files checked into the code repository.')
- previousNames('beam_SeedJob_Main')
-
- // Set common parameters.
- common_job_properties.setTopLevelMainJobProperties(delegate)
-
- // This is a post-commit job that runs once per day, not for every push.
- common_job_properties.setPostCommit(
- delegate,
- '0 6 * * *',
- false,
- 'dev@beam.apache.org')
-
- // Allows triggering this build against pull requests.
- common_job_properties.enablePhraseTriggeringFromPullRequest(
- delegate,
- 'Seed Job',
- 'Run Seed Job')
+ properties {
+ githubProjectUrl('https://github.com/apache/beam/')
+ }
+
+ jdk('JDK 1.8 (latest)')
+
+ // Restrict to only run on Jenkins executors labeled 'beam'
+ label('beam')
+
+ logRotator {
+ daysToKeep(14)
+ }
+
+ scm {
+ git {
+ remote {
+ github('apache/beam')
+
+ // ${ghprBuildId} is not interpolated by groovy, but passed through to Jenkins where it
+ // refers to the environment variable
+ refspec(['+refs/head/*:refs/remotes/origin/*'
+ '+refs/pull/${ghprPullId}/*:refs/remotes/origin/pr/${ghprPullId}/*']
+ .join(' '))
+
+ // The variable ${sha1} is not interpolated by groovy, but a parameter of the Jenkins job
+ branch('${sha1}')
+
+ extensions {
+ cleanAfterCheckout()
+ }
+ }
+ }
+ }
+
+ parameters {
+ // Setup for running this job from a pull request
+ stringParam(
+ 'sha1',
+ defaultBranch,
+ 'Commit id or refname (eg: origin/pr/4001/head) you want to build against.')
+ }
+
+ wrappers {
+ timeout {
+ absolute(5)
+ abortBuild()
+ }
+ }
+
+ triggers {
+ // Run once per day
+ cron('0 */6 * * *')
+
+ githubPullRequest {
+ admins(['asfbot'])
+ useGitHubHooks()
+ orgWhitelist(['apache'])
+ allowMembersOfWhitelistedOrgsAsAdmin()
+ permitAll()
+
+ // Also run when manually kicked on a pull request
+ triggerPhrase('Run Seed Job')
+ onlyTriggerPhrase()
+
+ extensions {
+ commitStatus {
+ context("Jenkins: Standalone Seed Job")
+ }
+
+ buildStatus {
+ completedStatus('SUCCESS', '--none--')
+ completedStatus('FAILURE', '--none--')
+ completedStatus('ERROR', '--none--')
+ }
+ }
+ }
+ }
+
+ // If anything goes wrong, mail the main dev list, because it is a big deal
+ publishers {
+ mailer('dev@beam.apache.org', false, true)
+ }
steps {
dsl {
|
kennknowles
commented
Oct 17, 2017
| * limitations under the License. | ||
| */ | ||
|
|
||
| import common_job_properties |
Member
Author
There was a problem hiding this comment.
Actually, this should be removed
Member
Author
|
The test results here indicate how urgent it is that we fix our testing situation - this PR touches nothing that is tested, yet both main precommits flaked. I think the first prerequisite step is to make it easy and safe to change testing rapidly to experiment. |
94d2f12 to
62d61da
Compare
Member
Author
|
run seed job |
62d61da to
58b3369
Compare
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.R: @jasonkuster