Skip to content

Clone source to a distinguished subdirectory of Jenkins workspace#3976

Merged
asfgit merged 1 commit intoapache:masterfrom
kennknowles:relative-git-dir
Oct 20, 2017
Merged

Clone source to a distinguished subdirectory of Jenkins workspace#3976
asfgit merged 1 commit intoapache:masterfrom
kennknowles:relative-git-dir

Conversation

@kennknowles
Copy link
Copy Markdown
Member

@kennknowles kennknowles commented Oct 10, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 10, 2017

run seed job

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 10, 2017

(canceled)

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 10, 2017

R: @jasonkuster especially looking for places where we need to adjust other properties

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 10, 2017

Particularly, is rootPOM relative to the workspace root or the clone?

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 20, 2017

Now that there is a standalone seed job as backup, this should be safe, before or after #4019.

tgroh
tgroh approved these changes Oct 20, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@tgroh tgroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 20, 2017

run seed job

1 similar comment
@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 20, 2017

run seed job

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 20, 2017

run go precommit

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 20, 2017

run java precommit

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 20, 2017

Confirmed that this change does not wedge the seed job. Since it is just kind of nicer anyhow, I am going ahead.

@asfgit asfgit merged commit 241d3ce into apache:master Oct 20, 2017
asfgit pushed a commit that referenced this pull request Oct 20, 2017
@kennknowles
This closes #3976: Clone source to a distinguished subdirectory of Je…
a29e0ad 
…nkins workspace
@kennknowles kennknowles deleted the relative-git-dir branch October 23, 2017 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgroh tgroh tgroh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kennknowles @tgroh @asfgit