Fix CVE-2025-48734, CVE-2024-13009#36106
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @stankiewicz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the project's security posture by updating several key library dependencies to their latest versions. These updates specifically address multiple Common Vulnerabilities and Exposures (CVEs), ensuring that the system is protected against known security flaws. The changes involve bumping versions for critical components like Hadoop, Netty, and Jetty, which are fundamental to the project's operation.
Highlights
- Hadoop Version Update: The Hadoop dependency version has been updated from 3.4.1 to 3.4.2, addressing identified security vulnerabilities.
- Netty Version Update: The Netty dependency version has been updated from 4.1.110.Final to 4.1.118.Final, resolving reported CVEs.
- Jetty Version Update: The Jetty dependency version has been updated from 9.4.54.v20240208 to 9.4.57.v20241219, mitigating security risks.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
| def log4j2_version = "2.20.0" | ||
| def nemo_version = "0.1" | ||
| // [bomupgrader] determined by: io.grpc:grpc-netty, consistent with: google_cloud_platform_libraries_bom | ||
| def netty_version = "4.1.110.Final" |
There was a problem hiding this comment.
Do we need to wait for the next gcp libraries bom upgrade for this?
There was a problem hiding this comment.
yeah, I guess you are right, com.google.cloud:libraries-bom:26.65.0 includes grpc-bom 1.6.1, and io.grpc:grpc-netty:1.61.1 includes 4.1.100.Final .
com.google.cloud:libraries-bom:26.67.0 is still using 1.61.1
There was a problem hiding this comment.
let us revert these from BOM and keep the other fixes.
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This reverts commit 874a77c.
|
removed netty changes |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36106 +/- ##
============================================
+ Coverage 54.90% 56.77% +1.86%
- Complexity 1617 3384 +1767
============================================
Files 1057 1220 +163
Lines 164005 185237 +21232
Branches 1165 3520 +2355
============================================
+ Hits 90055 105162 +15107
- Misses 71797 76736 +4939
- Partials 2153 3339 +1186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* update dependencies due to CVE-2024-13009 and CVE-2025-24970 * update dependency due to transitive dependency with CVE-2025-48734 * outstanding netty dependency. * fix netty's CVE-2025-55163 * Revert "fix netty's CVE-2025-55163" This reverts commit 874a77c. * revert netty
* update dependencies due to CVE-2024-13009 and CVE-2025-24970 * update dependency due to transitive dependency with CVE-2025-48734 * outstanding netty dependency. * fix netty's CVE-2025-55163 * Revert "fix netty's CVE-2025-55163" This reverts commit 874a77c. * revert netty
* update dependencies due to CVE-2024-13009 and CVE-2025-24970 * update dependency due to transitive dependency with CVE-2025-48734 * outstanding netty dependency. * fix netty's CVE-2025-55163 * Revert "fix netty's CVE-2025-55163" This reverts commit 874a77c. * revert netty Co-authored-by: Radosław Stankiewicz <radoslaws@google.com>
fixes
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.