[2.67.0 postrelease] Fix CVE-2025-48734, CVE-2024-13009 (#36106)#36111
Conversation
* update dependencies due to CVE-2024-13009 and CVE-2025-24970 * update dependency due to transitive dependency with CVE-2025-48734 * outstanding netty dependency. * fix netty's CVE-2025-55163 * Revert "fix netty's CVE-2025-55163" This reverts commit 874a77c. * revert netty
There was a problem hiding this comment.
Summary of Changes
Hello @kennknowles, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to enhance the security posture of the project by upgrading several key third-party libraries. These updates are specifically targeted at resolving identified Common Vulnerabilities and Exposures (CVEs), ensuring the stability and integrity of the system, particularly for the 2.67.0 postrelease branch.
Highlights
- Dependency Updates for Security: Critical dependencies including Hadoop, Jetty, and Netty have been updated to address CVEs.
- Cherry-pick to Post-Release Branch: This PR is a cherry-pick of #36106 to the 2.67.0 postrelease branch, ensuring automatic container updates with the fixes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Is this expected? |
I don't think so - it looks healthy at head. https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_Pulsar_IO_Direct.yml |
|
I wouldn't merge on "expected red" anyhow. Pulsar is quick enough to re-run if it is a flake, but it looks like it rarely is. The failures in the Java precommit are suites that have flaked on every recent PR I've opened, but I will ensure everything is green, or abandon. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-2.67.0-postrelease #36111 +/- ##
=============================================================
Coverage 56.56% 56.57%
- Complexity 3381 3382 +1
=============================================================
Files 1204 1204
Lines 183787 183787
Branches 3490 3490
=============================================================
+ Hits 103965 103972 +7
+ Misses 76496 76493 -3
+ Partials 3326 3322 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Confirmed locally running It does look like there is something flaky, potentially concurrent, about how we are claiming ranges in PulsarIO though. I've seen the same issue before. |
|
Green & merging |
66ed773
into
apache:release-2.67.0-postrelease
This cherrypicks #36106 to the 2.67.0 postrelease branch, where it should be automatically updating the containers.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.