TImeout StreamingDataflowWorkerTest when test stuck#29065
Merged
Abacn merged 1 commit intoapache:masterfrom Oct 19, 2023
Merged
TImeout StreamingDataflowWorkerTest when test stuck#29065Abacn merged 1 commit intoapache:masterfrom
Abacn merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
R: @ahmedabu98 |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Contributor
Author
|
e.g. this happened again in jenkins: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/28702/ |
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
Contributor
|
The notify could be called before we enter the synchronized block causing wait to wait indefinitely, this test should be fixed in #29041 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mitigate #28957
A testing PR #23785 found a stuck test path
this would make the test under this test class timeout after 600s, instead the whole test suite hanging indefinitely
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.