Skip to content

[Test only][Do not merge] Draft PR for testing remote runs#23785

Closed
Abacn wants to merge 1 commit intoapache:masterfrom
Abacn:flinkloadtestfix
Closed

[Test only][Do not merge] Draft PR for testing remote runs#23785
Abacn wants to merge 1 commit intoapache:masterfrom
Abacn:flinkloadtestfix

Conversation

@Abacn
Copy link
Copy Markdown
Contributor

@Abacn Abacn commented Oct 21, 2022

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the go label Oct 21, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d00303a) 38.32% compared to head (50810a2) 38.32%.
Report is 520 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #23785   +/-   ##
=======================================
  Coverage   38.32%   38.32%           
=======================================
  Files         688      688           
  Lines      101861   101861           
=======================================
+ Hits        39037    39041    +4     
+ Misses      61243    61240    -3     
+ Partials     1581     1580    -1
Flag Coverage Δ
go 53.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abacn Abacn closed this Nov 17, 2022
@Abacn Abacn reopened this Nov 17, 2022
@github-actions github-actions bot added the infra label Nov 17, 2022
@Abacn Abacn closed this Dec 13, 2022
@Abacn Abacn reopened this Dec 13, 2022
@apache apache deleted a comment from github-actions bot Dec 21, 2022
@Abacn Abacn force-pushed the flinkloadtestfix branch 2 times, most recently from 52b7015 to d02cc31 Compare December 28, 2022 21:32
@github-actions github-actions bot added build and removed io labels Dec 28, 2022
@Abacn Abacn force-pushed the flinkloadtestfix branch 2 times, most recently from ef7ece9 to de12082 Compare December 28, 2022 23:20
@Abacn Abacn force-pushed the flinkloadtestfix branch from de12082 to 530cfd7 Compare January 5, 2023 20:35
@Abacn Abacn force-pushed the flinkloadtestfix branch 2 times, most recently from 179d5bb to 8978e63 Compare January 27, 2023 20:07
@github-actions github-actions bot added io and removed infra labels Jan 27, 2023
@Abacn Abacn force-pushed the flinkloadtestfix branch 2 times, most recently from f4e4dd1 to 0cf3aad Compare February 1, 2023 21:21
@Abacn Abacn closed this Feb 1, 2023
@Abacn Abacn reopened this Feb 1, 2023
@Abacn Abacn mentioned this pull request May 10, 2023
Closed
15 tasks
@Abacn Abacn mentioned this pull request May 31, 2023
Merged
3 tasks
@Abacn Abacn mentioned this pull request Jul 27, 2023
Closed
15 tasks
@Abacn Abacn mentioned this pull request Oct 18, 2023
Merged
3 tasks
@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Nov 1, 2023 •
edited
Loading

Run XVR_Flink PostCommit

success run output:

00:11:35 print::::: [/home/jenkins/jenkins-slave/workspace/beam_PostCommit_XVR_Flink_PR/src/sdks/python/container/build/target/launcher]
00:11:35 print:::::  boot

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Nov 1, 2023

Confirm that the file exists when goBuild is run, but copyLauncherDependencies may still end up with NO-SOURCE:

https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink_PR/314/console

This might be a gradle bug

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Nov 1, 2023 •
edited
Loading

Run XVR_Flink PostCommit

Finally see another reproduce: https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink_PR/324/console

  • At gradle configuration time, configurations.pythonHarnessLauncher is indeed set:
13:04:47 > Configure project :sdks:python:container:py38
13:04:47 print----- /home/jenkins/jenkins-slave/workspace/beam_PostCommit_XVR_Flink_PR/src/sdks/python/container/build/target/launcher
13:04:48 System Go installation: /snap/bin/go is go version go1.16.15 linux/amd64; Preparing to use /home/jenkins/go/bin/go1.21.3
13:04:48 go1.21.3: already downloaded in /home/jenkins/sdk/go1.21.3
13:04:48 GOCMD=/home/jenkins/go/bin/go1.21.3
13:04:49 print+++++ /home/jenkins/jenkins-slave/workspace/beam_PostCommit_XVR_Flink_PR/src/sdks/python/container/build/target/launcher
  • Then, :sdks:python:container:goBuild indeed produced the binary:
13:05:39 > Task :sdks:python:container:goBuild
13:05:39 print:::::  /home/jenkins/jenkins-slave/workspace/beam_PostCommit_XVR_Flink_PR/src/sdks/python/container/build/target/launcher/linux_amd64/boot name:::: boot

However, sdks:python:container:py38:copyLauncherDependencies skipped as NO-SOURCE

13:05:39 > Task :sdks:python:container:py38:copyLauncherDependencies NO-SOURCE

which caused binary not copied into the folder for docker prepare

@Abacn Abacn mentioned this pull request Nov 1, 2023
Closed
16 tasks
@damondouglas
Copy link
Copy Markdown
Contributor

damondouglas commented Nov 16, 2023

Good day, @Abacn , May we consider closing this PR or do you still need it open?

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Nov 17, 2023

I used this PR to test various things and that's why it has a so long history.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 17, 2024

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docker python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Abacn @damondouglas