Conversation
Contributor
Author
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #27968 +/- ##
==========================================
+ Coverage 72.04% 72.31% +0.27%
==========================================
Files 674 678 +4
Lines 98577 99662 +1085
==========================================
+ Hits 71023 72074 +1051
- Misses 25991 26025 +34
Partials 1563 1563
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
liferoad
reviewed
Aug 11, 2023
johnjcasey
approved these changes
Aug 11, 2023
liferoad
approved these changes
Aug 11, 2023
BjornPrime
added a commit
to BjornPrime/my-beam
that referenced
this pull request
Aug 21, 2023
This reverts commit 8cfd308.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has caused some internal breakages, we should dig in to the changes before releasing them.
PR produced with:
Followed by manually resolving conflicts in setup.py and base_image_requirements.txt files. I removed the client change from setup.py and just updated the requirements files to not have any changes.
I also made a separate commit to revert the CHANGES.md update.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.