Skip to content

Replace StorageV1 client with GCS client (take 3)#27878

Merged
johnjcasey merged 1 commit intoapache:masterfrom
BjornPrime:new-storage-client
Aug 8, 2023
Merged

Replace StorageV1 client with GCS client (take 3)#27878
johnjcasey merged 1 commit intoapache:masterfrom
BjornPrime:new-storage-client

Conversation

@BjornPrime
Copy link
Copy Markdown
Contributor

@BjornPrime BjornPrime commented Aug 7, 2023

Addresses #25676.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@BjornPrime
Copy link
Copy Markdown
Contributor Author

BjornPrime commented Aug 7, 2023

Run Python 3.11 PostCommit

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #27878 (97d1208) into master (9ca6c33) will decrease coverage by 0.28%.
Report is 7 commits behind head on master.
The diff coverage is 47.72%.

❗ Current head 97d1208 differs from pull request most recent head 821f8fc. Consider uploading reports for the commit 821f8fc to get more accurate results

@@            Coverage Diff             @@
##           master   #27878      +/-   ##
==========================================
- Coverage   70.87%   70.59%   -0.28%     
==========================================
  Files         861      857       -4     
  Lines      105001   103916    -1085     
==========================================
- Hits        74417    73359    -1058     
+ Misses      29025    28998      -27     
  Partials     1559     1559
Flag Coverage Δ
python 79.55% <47.72%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...n/apache_beam/examples/complete/game/user_score.py 62.79% <ø> (ø)
sdks/python/apache_beam/io/gcp/bigquery_tools.py 74.82% <ø> (ø)
..._beam/runners/portability/sdk_container_builder.py 36.89% <0.00%> (-1.04%) ⬇️
sdks/python/setup.py 0.00% <ø> (ø)
...apache_beam/runners/dataflow/internal/apiclient.py 74.87% <34.61%> (-0.77%) ⬇️
sdks/python/apache_beam/io/gcp/gcsio.py 65.78% <49.56%> (-26.24%) ⬇️
sdks/python/apache_beam/internal/gcp/auth.py 78.37% <50.00%> (-0.79%) ⬇️
...ks/python/apache_beam/runners/interactive/utils.py 94.69% <90.00%> (-0.40%) ⬇️
sdks/python/apache_beam/io/gcp/gcsfilesystem.py 89.06% <100.00%> (+0.41%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BjornPrime BjornPrime mentioned this pull request Aug 7, 2023
Closed
3 tasks
@BjornPrime BjornPrime marked this pull request as ready for review August 7, 2023 19:58
@BjornPrime
Copy link
Copy Markdown
Contributor Author

BjornPrime commented Aug 7, 2023

Run Python 3.11 PostCommit

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 7, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.
R: @pabloem for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@johnjcasey johnjcasey merged commit 014a193 into apache:master Aug 8, 2023
damccorm added a commit that referenced this pull request Aug 11, 2023
@damccorm
Revert #27878 (#27968)
8cfd308 
* Merge in master

* Remove changes.md callout
damccorm added a commit that referenced this pull request Aug 11, 2023
@damccorm
Revert #27878 (#27968)
86ab14d 
* Merge in master

* Remove changes.md callout
lostluck pushed a commit that referenced this pull request Aug 11, 2023
@damccorm
Revert #27878 (#27968) (#27970)
50e2495 
* Merge in master

* Remove changes.md callout
BjornPrime added a commit to BjornPrime/my-beam that referenced this pull request Aug 21, 2023
@BjornPrime
Revert "Revert apache#27878 (apache#27968)"
4da1049 
This reverts commit 8cfd308.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docker examples gcp io Next Action: Reviewers python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BjornPrime @johnjcasey