[BEAM-13430] Re-add provided configuration #16552

emilymye · 2022-01-18T20:29:43Z

Several dependencies were migrated from provided to compileOnly in #16308 - this reverses these changes and adds a provided configuration to behave similarly to provided from the propdeps plugin

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

`ValidatesRunner` compliance status (on master branch)

Lang	ULR	Twister2
Go	---	---
Java
Python	---	---
XLang		---

Examples testing status on various runners

Lang	ULR	Dataflow	Flink	Samza	Spark	Twister2
Go	---	---	---	---	---	---	---
Java	---		---	---	---	---	---
Python	---	---	---	---	---	---	---
XLang	---	---	---	---	---	---	---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go	Java	Python

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---			---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

codecov · 2022-01-18T21:15:06Z

Codecov Report

Merging #16552 (c1958b3) into master (50e7235) will increase coverage by 37.28%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #16552       +/-   ##
===========================================
+ Coverage   46.32%   83.60%   +37.28%     
===========================================
  Files         201      452      +251     
  Lines       19734    62072    +42338     
===========================================
+ Hits         9141    51897    +42756     
- Misses       9612    10175      +563     
+ Partials      981        0      -981

Impacted Files	Coverage Δ
sdks/go/pkg/beam/core/runtime/coderx/string.go
sdks/go/pkg/beam/core/graph/coder/registry.go
sdks/go/pkg/beam/core/runtime/init.go
sdks/go/pkg/beam/artifact/stage.go
sdks/go/pkg/beam/core/graph/coder/double.go
sdks/go/pkg/beam/transforms/stats/stats.shims.go
sdks/go/pkg/beam/core/graph/coder/panes.go
sdks/go/pkg/beam/io/bigqueryio/bigquery.go
sdks/go/pkg/beam/core/runtime/genx/genx.go
sdks/go/pkg/beam/transforms/top/top.go
... and 643 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50e7235...c1958b3. Read the comment docs.

emilymye · 2022-01-19T05:29:04Z

sdks/java/container/common.gradle

I think this might be a new things we need for Gradle 7 (gradle/gradle#17236)

The comments on that bug are 😨

emilymye · 2022-01-19T05:32:42Z

R: @kennknowles @dpcollins-google @TheNeuralBit

emilymye · 2022-01-19T05:33:24Z

Run Java PostCommit

dpcollins-google · 2022-01-19T09:48:52Z

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

This should be "testImplementation"

kennknowles

This seems like a really good way to get forward progress without blocking on the discussion.

emilymye · 2022-01-19T22:27:14Z

Run Java PreCommit

aaltay · 2022-01-20T02:15:09Z

Is this ready to be merged except for the failing test?

aaltay · 2022-01-20T02:15:24Z

Run Java PreCommit

aaltay · 2022-01-20T02:15:38Z

Reference to previously failing test: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/20640/

emilymye · 2022-01-20T16:47:59Z

The failing test is related, but the solution is not clear, hence not merging.

aaltay · 2022-01-20T17:12:55Z

The failing test is related, but the solution is not clear, hence not merging.

Ack. Thank you. Please ask for help if you need.

emilymye · 2022-01-20T23:07:28Z

Run Portable_Python PreCommit

emilymye · 2022-01-21T00:22:58Z

Confirmed that POMs match previous (2.35.0) POMs with provided scopes

kennknowles

heroic work figuring this out

* github/master: (198 commits) Merge pull request apache#16369 from [BEAM-13558] [Playground] Hide the Graph tab and SCIO from SDK options Merge pull request apache#16546 from [BEAM-13661] [BEAM-13704] [Playground] Update tags for examples/katas/unit-tests Merge pull request apache#16540 from [BEAM-13678][Playground]Update Github Action To Deploy Examples [BEAM-13430] Re-add provided configuration (apache#16552) [BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks (apache#16575) [BEAM-13693] Bump beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming timeout to 12 hours (apache#16576) [BEAM-13699] Replace fnv with maphash. (apache#16573) Update Java FnAPI beam master (apache#16572) Merge pull request apache#16371 from [BEAM-13518][Playground] Beam Playground quickstart page on the Beam website Merge pull request apache#16373 from [BEAM-13515] [Playground] Hiding lines in an example that are not necessary Merge pull request apache#16472: [BEAM-13697] Add SchemaFieldNumber annotation [BEAM-13689] Output token elements when BQ batch writes complete. Disable logging for memoization test. (apache#16556) BEAM-13611 reactivating jdbcio xlang test Revert "Merge pull request apache#15863 from [BEAM-13184] Autosharding for JdbcIO.write* transforms" Remove obsolete commands from Inventory job. (apache#16564) [BEAM-13688] fixed type in BPG 4.5.3 window section (apache#16560) [BEAM-13683] Make cross-language SQL example pipeline (apache#16567) Merge pull request apache#16243 from darshan-sj/feature/support-priority-spannerio - Making rpcPriority a ValueProvider in SpannerConfig edited README and comments in Python multi-lang pipes examples Merge pull request apache#16518 from [BEAM-13619] [Playground] Add loading animation to the catalog Merge pull request apache#16519 from [BEAM-13639] [Playground] Add notification to Log/Output tabs about cached example Merge pull request apache#16533 from [BEAM-13548] [Playground] Add example description popover Merge pull request apache#16531 from [BEAM-13567] [playground] Handle run code validation and preparation errors Merge pull request apache#16370 from [BEAM-13556] playground - color and scroll tabs with new content [BEAM-13611] Skip test_xlang_jdbc_write (apache#16554) [BEAM-13015] Provide caching statistics in the status client. (apache#16495) Merge pull request apache#16309: [BEAM-13503] Set a default value to throwWriteErrors in BulkIO constructor [BEAM-13015] Add state caching capability to be used as hint for runners to not duplicate cached data if the SDK can do it for user state and side inputs. (apache#16525) [BEAM-13665] Make SpannerIO projectID optional again (apache#16547) Merge pull request apache#16322 from [BEAM-13407] [Playground] Preload fonts for the web application Merge pull request apache#16506 from [BEAM-13652][Playground] Send examples' links to the frontend [BEAM-11808][BEAM-9879] Support aggregate functions with two arguments (apache#16200) Update walkthrough.md (apache#16512) [BEAM-13683] Correct SQL transform schema, fix expansion address override bug (apache#16551) Merge pull request apache#16486 from [BEAM-13544][Playground] Add logs to examples CI/CD to see the progress [BEAM-13616][BEAM-13646] Upgrade vendored calcite to 1.28.0:0.2 (apache#16544) [BEAM-13616][BEAM-13645] Switch to vendored grpc 1.43.2 (apache#16543) Also bump FnAPI container. [BEAM-13680] Fixed code_repository (added pipelineUuid to RunCodeResult when status is "Finished") [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0 (apache#16509) [BEAM-13430] Remove jcenter which will no longer contain any updates. (apache#16536) Update GH Actions to use proper variables names and proper triggers Remove jcenter repositories from gradle configuration. (apache#16532) Merge pull request apache#16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api and index.store.stats_refresh_interval=0 [BEAM-13664] Fix Primitives hashing benchmark (apache#16523) Bump beam container version. [BEAM-12621] - Update Jenkins VMs to modern Ubuntu version (apache#16457) doc tweaks (apache#16498) Redirecting cross-language transforms content (apache#16504) Remove tab from source. Remove unnecessary fmt call in universal.go Clean up string cast of bytes in vet.go and corresponding tests fix capitalized error strings in expansionx Remove unnecessary blank identifier assignment in harness.go Replace string(buf.Bytes()) with buf.String() in coder_test.go Replace bytes.Compare() with bytes.Equal() in test cases Remove unnecessary fmt.Sprintf() in partition.go Fix staticcheck errors in transforms directory [BEAM-13590] Fix abc imports from collections (apache#15850) Merge pull request apache#16482 from [BEAM-13429][Playground] Add builder for preparers [BEAM-10206] Resolve go vet errors in protox package [BEAM-12572] Run java examples on multiple runners (apache#16450) [BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types and OTHER JDBC types in general [BEAM-13577] Beam Select's uniquifyNames function loses nullability of Complex types while inferring schema [BEAM-12164]: Add SDF for reading change stream records [BEAM-13455] Remove duplicated artifacts when using multiple environments with Dataflow Java Merge pull request apache#16485 from [BEAM-13486] [Playground] For unit tests (java) if one of tests fails the output goes to stdOutput Merge pull request apache#16385 from [BEAM-13535] [Playground] add cancel execution button [BEAM-12558] Fix doc typo. Merge pull request apache#16467 from [BEAM-12164]: SpannerIO DetectNewPartitions SDF Introduce the notion of a JoinIndex for fewer shuffles. (apache#16101) [BEAM-12464] Change ProtoSchemaTranslator beam schema creation to match the order for protobufs containing Oneof fields (apache#14974) Stronger typing inference for CoGBK. (apache#16465) [BEAM-13480] Increase pipeline timeout for PubSubIntegrationTest.test_streaming_data_only (apache#16496) Provide API to check whether a hint is known. [BEAM-8806] Integration test for SqsIO using Localstack Split builder into several builder for each step of pipeline execution [BEAM-13399] Move service liveness polling to Runner type (apache#16487) Merge pull request apache#16325 from [BEAM-13471] [Playground] Tag existing unit-tests Adds several example multi-language Python pipelines [BEAM-13616][BEAM-13646] Update vendored calcite 1.28.0 with protobuf 3.19.2 (apache#16473) Merge pull request apache#16374 from [BEAM-13398][Playground] Split LifeCycle to DTO and business logic Merge pull request apache#16363 from [BEAM-13557] [Playground] show code execution time Merge pull request apache#16149 from [BEAM-13113] [Playground] playground frontend documentation Merge pull request apache#16469 from [BEAM-13623][Playground] [Bugfix] During unit tests failing there is no any output [BEAM-13641][Playground] Add SCIO SDK support on the CI/CD step [BEAM-13638] Datatype of timestamp fields in SqsMessage for AWS IOs for SDK v2 was changed from String to long, visibility of all fields was fixed from package private to public [BEAM-13616] Initial files for vendored gRPC 1.43.2 (apache#16460) [BEAM-13432] Skip ExpansionService creation in Job Server (apache#16222) [BEAM-13628] Update SideInputCache to use full Transform and SideInputIDs as token information (apache#16483) [BEAM-13631] Add deterministic SQS message coder to fix reading from SQS in batch mode [BEAM-8806] Integration test for SqsIO [adhoc] Run spotlessApply on java examples to fix master Merge pull request apache#16156 from [BEAM-13391] Fix temporary file format in WriteToBigQuery Optional args and kwargs for named external transforms. [BEAM-13614] Add OnWindowExpiration support to the Java SDK harness and proto translation. (apache#16458) [BEAM-3221] Improve documentation in model pipeline protos (apache#16474) Merge pull request apache#16147 from [BEAM-13359] [Playground] Tag existing examples [BEAM-13626] Remap expanded outputs after merging. (apache#16471) ...

emilymye · 2022-02-02T06:46:37Z

jk - followup is #16688 (it did add back provided, but it also accidently added compile as well :S)

emilymye changed the title ~~[BEAM-13430] Re-add a provided configuration~~ [BEAM-13430] Re-add provided configuration Jan 18, 2022

emilymye force-pushed the provideddeps branch 5 times, most recently from f33390d to 54c16ce Compare January 19, 2022 05:12

emilymye commented Jan 19, 2022

View reviewed changes

emilymye marked this pull request as ready for review January 19, 2022 05:32

emilymye requested review from TheNeuralBit and kennknowles January 19, 2022 05:33

dpcollins-google reviewed Jan 19, 2022

View reviewed changes

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy Outdated

Copy link

Contributor

dpcollins-google Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "testImplementation"

kennknowles approved these changes Jan 19, 2022

View reviewed changes

emilymye force-pushed the provideddeps branch from fb80f2c to ce05a6f Compare January 20, 2022 00:03

revert provided from compileOnly

f2f6c8e

emilymye force-pushed the provideddeps branch from beecea0 to f2f6c8e Compare January 20, 2022 22:43

change sdks:java:harness to shadow, not shadowTest

c1958b3

emilymye removed the request for review from TheNeuralBit January 21, 2022 00:22

kennknowles approved these changes Jan 21, 2022

View reviewed changes

emilymye merged commit e3c24f0 into apache:master Jan 21, 2022

emilymye deleted the provideddeps branch January 21, 2022 00:28

[BEAM-13430] Re-add provided configuration #16552

[BEAM-13430] Re-add provided configuration #16552

Uh oh!

Conversation

emilymye commented Jan 18, 2022

ValidatesRunner compliance status (on master branch)

Examples testing status on various runners

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Pre-Commit Tests Status (on master branch)

GitHub Actions Tests Status (on master branch)

Uh oh!

codecov bot commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

emilymye Jan 19, 2022

Choose a reason for hiding this comment

Uh oh!

kennknowles Jan 19, 2022

Choose a reason for hiding this comment

Uh oh!

emilymye commented Jan 19, 2022

Uh oh!

emilymye commented Jan 19, 2022

Uh oh!

dpcollins-google Jan 19, 2022

Choose a reason for hiding this comment

Uh oh!

kennknowles left a comment

Choose a reason for hiding this comment

Uh oh!

emilymye commented Jan 19, 2022

Uh oh!

aaltay commented Jan 20, 2022

Uh oh!

aaltay commented Jan 20, 2022

Uh oh!

aaltay commented Jan 20, 2022

Uh oh!

emilymye commented Jan 20, 2022

Uh oh!

aaltay commented Jan 20, 2022

Uh oh!

emilymye commented Jan 20, 2022

Uh oh!

emilymye commented Jan 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kennknowles left a comment

Choose a reason for hiding this comment

Uh oh!

emilymye commented Feb 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

`ValidatesRunner` compliance status (on master branch)

codecov bot commented Jan 18, 2022 •

edited

Loading

emilymye commented Jan 21, 2022 •

edited

Loading