[BEAM-13471] [Playground] Tag existing unit-tests #16325

pavel-avilov · 2021-12-22T15:44:24Z

[BEAM-13471]
Tag existing unit-tests

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

`ValidatesRunner` compliance status (on master branch)

Lang	ULR	Twister2
Go	---	---
Java
Python	---	---
XLang		---

Examples testing status on various runners

Lang	ULR	Dataflow	Flink	Samza	Spark	Twister2
Go	---	---	---	---	---	---	---
Java	---		---	---	---	---	---
Python	---	---	---	---	---	---	---
XLang	---	---	---	---	---	---	---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go	Java	Python

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website	Whitespace	Typescript
Non-portable
Portable	---			---	---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

codecov · 2021-12-23T07:54:57Z

Codecov Report

Merging #16325 (d9f166e) into master (0ef6d4b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #16325      +/-   ##
==========================================
- Coverage   74.67%   74.63%   -0.05%     
==========================================
  Files         644      647       +3     
  Lines       81264    81340      +76     
==========================================
+ Hits        60684    60705      +21     
- Misses      19609    19664      +55     
  Partials      971      971

Impacted Files	Coverage Δ
sdks/python/apache_beam/utils/interactive_utils.py	`90.24% <0.00%> (-2.44%)`	⬇️
sdks/python/apache_beam/internal/metrics/metric.py	`90.00% <0.00%> (-1.00%)`	⬇️
.../apache_beam/runners/direct/transform_evaluator.py	`90.31% <0.00%> (-0.14%)`	⬇️
sdks/python/apache_beam/io/gcp/pubsub.py	`90.65% <0.00%> (-0.05%)`	⬇️
setup.py	`0.00% <0.00%> (ø)`
sdks/python/apache_beam/testing/test_utils.py	`100.00% <0.00%> (ø)`
.../python/apache_beam/io/gcp/tests/pubsub_matcher.py	`90.47% <0.00%> (ø)`
...s/python/apache_beam/io/gcp/pubsublite/__init__.py	`0.00% <0.00%> (ø)`
.../python/apache_beam/io/gcp/pubsublite/proto_api.py	`0.00% <0.00%> (ø)`
...s/python/apache_beam/io/gcp/pubsublite/external.py	`0.00% <0.00%> (ø)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef6d4b...d9f166e. Read the comment docs.

KhaninArtur · 2021-12-23T14:48:54Z

examples/java/src/test/java/org/apache/beam/examples/complete/game/GameStatsTest.java

+//   description: Unit-test for the GameStats example.
+//   multifile: false
+//   pipeline_options:
+//   categories:


Suggested change

// categories:

// categories:

// - Testing

KhaninArtur · 2021-12-23T15:35:27Z

sdks/go/pkg/beam/partition_test.go

+//   description: Unit-test for the Partition example.
+//   multifile: false
+//   pipeline_options:
+//   categories:


Suggested change

// categories:

// categories:

// - Testing

KhaninArtur · 2021-12-23T15:36:22Z

sdks/go/pkg/beam/testing/ptest/ptest.go


+// beam-playground:
+//   name: PTest
+//   description: Contains utilities for pipeline unit testing.


Why do we need utilities? Do they test anything?

Oh, the package doesn't really test anything. Remove tag.

KhaninArtur · 2021-12-23T15:44:53Z

sdks/go/test/integration/xlang/xlang_test.go

+//   pipeline_options:
+//   categories:
+//     - Combiners
+//	   - Testing


Suggested change

// - Testing

// - Testing

I don't understand why it is displayed like this, but in the code it is correct.

Let's remove this file as well, it's hard to understand and it also seems like not related to Playground users

KhaninArtur · 2021-12-23T15:47:39Z

sdks/python/apache_beam/metrics/metric_test.py

+#   multifile: false
+#   pipeline_options:
+#   categories:
+#	  - Metrics


Suggested change

# - Metrics

# - Metrics

KhaninArtur

Let's think about categories for unit tests as categories of what is tested.

KhaninArtur · 2021-12-28T11:49:19Z

examples/java/src/test/java/org/apache/beam/examples/complete/TfIdfTest.java

+//   multifile: false
+//   pipeline_options:
+//   categories:
+//     - Side Input


Suggested change

// - Side Input

// - Side Input

// - Flatten

KhaninArtur · 2021-12-28T11:50:49Z

examples/java/src/test/java/org/apache/beam/examples/complete/game/GameStatsTest.java

+//   multifile: false
+//   pipeline_options:
+//   categories:
+//     - Testing


Suggested change

// - Testing

// - Testing

// - Filtering

KhaninArtur · 2021-12-28T11:53:08Z

...es/java/src/test/java/org/apache/beam/examples/complete/kafkatopubsub/KafkaToPubsubTest.java

+// beam-playground:
+//   name: KafkaToPubsubTest
+//   description: Unit-test for the KafkaToPubsub example.
+//   multifile: false
+//   pipeline_options:
+//   categories:
+//     - Streaming
+


Let's remove this file, it doesn't test anything related to Beam

KhaninArtur · 2021-12-28T11:54:16Z

examples/java/src/test/java/org/apache/beam/examples/cookbook/DistinctExampleTest.java

+//     - IO
+//     - Options


Suggested change

// - IO

// - Options

// - Core Transforms

// - Filtering

KhaninArtur · 2021-12-28T11:56:43Z

sdks/go/pkg/beam/core/util/symtab/symtab_test.go

+// beam-playground:
+//   name: SymtabTest
+//   description: Unit-test for the Symtab example.
+//   multifile: false
+//   pipeline_options:
+//   categories:
+//     - Side Input
+


Let's remove this file, it doesn't test anything related to Beam

KhaninArtur · 2021-12-28T12:22:45Z

sdks/python/apache_beam/examples/wordcount_minimal_test.py

+#   multifile: false
+#   pipeline_options:
+#   categories:
+#     - IO


Suggested change

# - IO

# - IO

# - Combiners

KhaninArtur · 2021-12-28T12:23:16Z

sdks/python/apache_beam/examples/wordcount_test.py

+#   multifile: false
+#   pipeline_options:
+#   categories:
+#     - IO


Suggested change

# - IO

# - IO

# - Combiners

KhaninArtur · 2021-12-28T12:24:09Z

sdks/python/apache_beam/io/filesystemio_test.py

+# beam-playground:
+#   name: FileSystemIOTest
+#   description: Unit-test for the FileSystemIO example.
+#   multifile: false
+#   pipeline_options:
+#   categories:
+#     - IO
+


Let's remove this file, it tests Beam internals

KhaninArtur · 2021-12-28T12:26:01Z

sdks/python/apache_beam/transforms/window_test.py

+# beam-playground:
+#   name: MetricTest
+#   description: Unit-test for the Window example.
+#   multifile: false
+#   pipeline_options:
+#   categories:
+#     - Core Transforms
+#	  - Windowing
+


Let's remove this file, it tests Beam internals

KhaninArtur · 2021-12-28T12:27:06Z

sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowingTest.java

+// beam-playground:
+//   name: WindowingTest
+//   description: Unit-test for the Windowing kata.
+//   multifile: false
+//   pipeline_options:
+//   categories:
+//     - Windowing
+//     - Streaming
+


Let's remove this file, it tests Beam internals

pavel-avilov · 2021-12-29T14:17:56Z

@KhaninArtur I added all suggested changes and remove several tags.

KhaninArtur

LGTM

ilya-kozyrev

LGTM

daria-malkova

LGTM

pabloem · 2022-01-10T23:39:12Z

sdks/python/apache_beam/transforms/sql_test.py

+#   multifile: false
+#   pipeline_options:
+#   categories:
+#     - Beam SQL


have you tested that these examples run well on the playground?

Hi Pablo, yes, all these examples have been tested and completed without errors

pabloem

this looks alright to me. I just have a question about the Beam SQL examples - have you verified that they work properly?

pabloem · 2022-01-12T17:37:36Z

LGTM

pabloem · 2022-01-12T17:37:44Z

Run Java PreCommit

pabloem · 2022-01-12T17:51:40Z

Run Java PreCommit

pabloem · 2022-01-12T17:53:01Z

Run Java_PVR_Flink_Docker PreCommit

pabloem · 2022-01-12T18:09:21Z

Run Java PreCommit

* github/master: (198 commits) Merge pull request apache#16369 from [BEAM-13558] [Playground] Hide the Graph tab and SCIO from SDK options Merge pull request apache#16546 from [BEAM-13661] [BEAM-13704] [Playground] Update tags for examples/katas/unit-tests Merge pull request apache#16540 from [BEAM-13678][Playground]Update Github Action To Deploy Examples [BEAM-13430] Re-add provided configuration (apache#16552) [BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks (apache#16575) [BEAM-13693] Bump beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming timeout to 12 hours (apache#16576) [BEAM-13699] Replace fnv with maphash. (apache#16573) Update Java FnAPI beam master (apache#16572) Merge pull request apache#16371 from [BEAM-13518][Playground] Beam Playground quickstart page on the Beam website Merge pull request apache#16373 from [BEAM-13515] [Playground] Hiding lines in an example that are not necessary Merge pull request apache#16472: [BEAM-13697] Add SchemaFieldNumber annotation [BEAM-13689] Output token elements when BQ batch writes complete. Disable logging for memoization test. (apache#16556) BEAM-13611 reactivating jdbcio xlang test Revert "Merge pull request apache#15863 from [BEAM-13184] Autosharding for JdbcIO.write* transforms" Remove obsolete commands from Inventory job. (apache#16564) [BEAM-13688] fixed type in BPG 4.5.3 window section (apache#16560) [BEAM-13683] Make cross-language SQL example pipeline (apache#16567) Merge pull request apache#16243 from darshan-sj/feature/support-priority-spannerio - Making rpcPriority a ValueProvider in SpannerConfig edited README and comments in Python multi-lang pipes examples Merge pull request apache#16518 from [BEAM-13619] [Playground] Add loading animation to the catalog Merge pull request apache#16519 from [BEAM-13639] [Playground] Add notification to Log/Output tabs about cached example Merge pull request apache#16533 from [BEAM-13548] [Playground] Add example description popover Merge pull request apache#16531 from [BEAM-13567] [playground] Handle run code validation and preparation errors Merge pull request apache#16370 from [BEAM-13556] playground - color and scroll tabs with new content [BEAM-13611] Skip test_xlang_jdbc_write (apache#16554) [BEAM-13015] Provide caching statistics in the status client. (apache#16495) Merge pull request apache#16309: [BEAM-13503] Set a default value to throwWriteErrors in BulkIO constructor [BEAM-13015] Add state caching capability to be used as hint for runners to not duplicate cached data if the SDK can do it for user state and side inputs. (apache#16525) [BEAM-13665] Make SpannerIO projectID optional again (apache#16547) Merge pull request apache#16322 from [BEAM-13407] [Playground] Preload fonts for the web application Merge pull request apache#16506 from [BEAM-13652][Playground] Send examples' links to the frontend [BEAM-11808][BEAM-9879] Support aggregate functions with two arguments (apache#16200) Update walkthrough.md (apache#16512) [BEAM-13683] Correct SQL transform schema, fix expansion address override bug (apache#16551) Merge pull request apache#16486 from [BEAM-13544][Playground] Add logs to examples CI/CD to see the progress [BEAM-13616][BEAM-13646] Upgrade vendored calcite to 1.28.0:0.2 (apache#16544) [BEAM-13616][BEAM-13645] Switch to vendored grpc 1.43.2 (apache#16543) Also bump FnAPI container. [BEAM-13680] Fixed code_repository (added pipelineUuid to RunCodeResult when status is "Finished") [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0 (apache#16509) [BEAM-13430] Remove jcenter which will no longer contain any updates. (apache#16536) Update GH Actions to use proper variables names and proper triggers Remove jcenter repositories from gradle configuration. (apache#16532) Merge pull request apache#16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api and index.store.stats_refresh_interval=0 [BEAM-13664] Fix Primitives hashing benchmark (apache#16523) Bump beam container version. [BEAM-12621] - Update Jenkins VMs to modern Ubuntu version (apache#16457) doc tweaks (apache#16498) Redirecting cross-language transforms content (apache#16504) Remove tab from source. Remove unnecessary fmt call in universal.go Clean up string cast of bytes in vet.go and corresponding tests fix capitalized error strings in expansionx Remove unnecessary blank identifier assignment in harness.go Replace string(buf.Bytes()) with buf.String() in coder_test.go Replace bytes.Compare() with bytes.Equal() in test cases Remove unnecessary fmt.Sprintf() in partition.go Fix staticcheck errors in transforms directory [BEAM-13590] Fix abc imports from collections (apache#15850) Merge pull request apache#16482 from [BEAM-13429][Playground] Add builder for preparers [BEAM-10206] Resolve go vet errors in protox package [BEAM-12572] Run java examples on multiple runners (apache#16450) [BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types and OTHER JDBC types in general [BEAM-13577] Beam Select's uniquifyNames function loses nullability of Complex types while inferring schema [BEAM-12164]: Add SDF for reading change stream records [BEAM-13455] Remove duplicated artifacts when using multiple environments with Dataflow Java Merge pull request apache#16485 from [BEAM-13486] [Playground] For unit tests (java) if one of tests fails the output goes to stdOutput Merge pull request apache#16385 from [BEAM-13535] [Playground] add cancel execution button [BEAM-12558] Fix doc typo. Merge pull request apache#16467 from [BEAM-12164]: SpannerIO DetectNewPartitions SDF Introduce the notion of a JoinIndex for fewer shuffles. (apache#16101) [BEAM-12464] Change ProtoSchemaTranslator beam schema creation to match the order for protobufs containing Oneof fields (apache#14974) Stronger typing inference for CoGBK. (apache#16465) [BEAM-13480] Increase pipeline timeout for PubSubIntegrationTest.test_streaming_data_only (apache#16496) Provide API to check whether a hint is known. [BEAM-8806] Integration test for SqsIO using Localstack Split builder into several builder for each step of pipeline execution [BEAM-13399] Move service liveness polling to Runner type (apache#16487) Merge pull request apache#16325 from [BEAM-13471] [Playground] Tag existing unit-tests Adds several example multi-language Python pipelines [BEAM-13616][BEAM-13646] Update vendored calcite 1.28.0 with protobuf 3.19.2 (apache#16473) Merge pull request apache#16374 from [BEAM-13398][Playground] Split LifeCycle to DTO and business logic Merge pull request apache#16363 from [BEAM-13557] [Playground] show code execution time Merge pull request apache#16149 from [BEAM-13113] [Playground] playground frontend documentation Merge pull request apache#16469 from [BEAM-13623][Playground] [Bugfix] During unit tests failing there is no any output [BEAM-13641][Playground] Add SCIO SDK support on the CI/CD step [BEAM-13638] Datatype of timestamp fields in SqsMessage for AWS IOs for SDK v2 was changed from String to long, visibility of all fields was fixed from package private to public [BEAM-13616] Initial files for vendored gRPC 1.43.2 (apache#16460) [BEAM-13432] Skip ExpansionService creation in Job Server (apache#16222) [BEAM-13628] Update SideInputCache to use full Transform and SideInputIDs as token information (apache#16483) [BEAM-13631] Add deterministic SQS message coder to fix reading from SQS in batch mode [BEAM-8806] Integration test for SqsIO [adhoc] Run spotlessApply on java examples to fix master Merge pull request apache#16156 from [BEAM-13391] Fix temporary file format in WriteToBigQuery Optional args and kwargs for named external transforms. [BEAM-13614] Add OnWindowExpiration support to the Java SDK harness and proto translation. (apache#16458) [BEAM-3221] Improve documentation in model pipeline protos (apache#16474) Merge pull request apache#16147 from [BEAM-13359] [Playground] Tag existing examples [BEAM-13626] Remap expanded outputs after merging. (apache#16471) ...

pavel-avilov added 2 commits December 22, 2021 18:40

Tag java unit-test

833d251

Tag go unit-test

54f5d4f

pavel-avilov added 3 commits December 23, 2021 11:17

Tag python unit-test

a6b77a1

Update tags

12c8f5f

Fix checks

ffcf94f

KhaninArtur suggested changes Dec 23, 2021

View reviewed changes

Edit tags

1c6c3f6

KhaninArtur suggested changes Dec 28, 2021

View reviewed changes

Update tags

d9f166e

KhaninArtur approved these changes Dec 29, 2021

View reviewed changes

ilya-kozyrev approved these changes Jan 10, 2022

View reviewed changes

daria-malkova approved these changes Jan 10, 2022

View reviewed changes

pabloem reviewed Jan 10, 2022

View reviewed changes

pabloem merged commit 1fa12d9 into apache:master Jan 12, 2022

-//     - IO
-//     - Options
+//     - Core Transforms
+//     - Filtering

[BEAM-13471] [Playground] Tag existing unit-tests #16325

[BEAM-13471] [Playground] Tag existing unit-tests #16325

Uh oh!

Conversation

pavel-avilov commented Dec 22, 2021

ValidatesRunner compliance status (on master branch)

Examples testing status on various runners

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Pre-Commit Tests Status (on master branch)

GitHub Actions Tests Status (on master branch)

Uh oh!

codecov bot commented Dec 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KhaninArtur left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pavel-avilov commented Dec 29, 2021

Uh oh!

KhaninArtur left a comment

Choose a reason for hiding this comment

Uh oh!

ilya-kozyrev left a comment

Choose a reason for hiding this comment

Uh oh!

daria-malkova left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pavel-avilov Jan 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pabloem left a comment

Choose a reason for hiding this comment

Uh oh!

`ValidatesRunner` compliance status (on master branch)

codecov bot commented Dec 23, 2021 •

edited

Loading

pavel-avilov Jan 11, 2022 •

edited

Loading