feat(go/adbc/driver/flightsql): propagate cookies to sub-clients#1497
Merged
lidavidm merged 2 commits intoapache:mainfrom Jan 30, 2024
Merged
feat(go/adbc/driver/flightsql): propagate cookies to sub-clients#1497lidavidm merged 2 commits intoapache:mainfrom
lidavidm merged 2 commits intoapache:mainfrom
Conversation
2d02377 to
41a6a1d
Compare
Member
|
Thanks for the R changes...before 0.10.0 / Arrow 16 I will try to update arrow/go so that |
lidavidm
approved these changes
Jan 30, 2024
| ts.addr = "grpc://" + suite.s.Addr().String() | ||
| } | ||
|
|
||
| func (suite *CookieTests) TestCookieUsage() { |
Member
There was a problem hiding this comment.
Can we add a specific test to make sure the token/cookies are copied?
Member
Author
There was a problem hiding this comment.
The modification i made to the test https://github.com/apache/arrow-adbc/pull/1497/files#diff-fff4d523df1762b32c2cd86dbe03bd2ec80fe856fc91471f24604909486824efL1098 does this
Member
There was a problem hiding this comment.
Hmm, the client cache isn't shared between metadata/data? Looks like not. That may be something we want to fix in the future so this test may be a little unstable in that case.
soumyadsanyal
pushed a commit
to soumyadsanyal/arrow-adbc
that referenced
this pull request
Jan 31, 2024
…che#1497) Closes apache#1194 This also bumps our dependency up to arrow v16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1194
This also bumps our dependency up to arrow v16