Skip to content

go/adbc/driver/flightsql: When CookiesMiddleware is enabled, DO_GET requests have a different set of cookies #1194

@aiguofer

Description

@aiguofer

I noticed that when cookies are enabled, DO_GET requests seem to be on their own set of cookies while other methods (only tested with GET_FLIGHT_INFO and DO_ACTION) seem to be on another set of cookies.

For example, here's a sequence of logs from establishing a connection and issuing a query, setting a "session_id" in the cookies if not already provided in the cookies:

Through JDBC:

{
  "@timestamp" : "2023-10-11 22:53:05.446",
  "message" : "Call started",
  "thread_name" : "flight-server-default-executor-0",
  "level" : "DEBUG",
  "request_id" : "b988e6c9-eb14-4e16-95a5-0ce66cd5acdb",
  "session" : "777a01f4-e6d9-4229-aa96-66d95517a241",
  "method" : "HANDSHAKE"
}
{
  "@timestamp" : "2023-10-11 22:53:08.772",
  "message" : "Call started",
  "thread_name" : "flight-server-default-executor-1",
  "level" : "DEBUG",
  "request_id" : "f83cc5b4-053d-42ca-becf-3628eb365f8c",
  "session" : "777a01f4-e6d9-4229-aa96-66d95517a241",
  "method" : "DO_ACTION"
}
{
  "@timestamp" : "2023-10-11 22:53:10.453",
  "message" : "Call started",
  "thread_name" : "flight-server-default-executor-1",
  "level" : "DEBUG",
  "request_id" : "f7f19a9c-086c-4327-94d0-467826f150d7",
  "session" : "777a01f4-e6d9-4229-aa96-66d95517a241",
  "method" : "GET_FLIGHT_INFO"
}
{
  "@timestamp" : "2023-10-11 22:53:10.496",
  "message" : "Call started",
  "thread_name" : "flight-server-default-executor-1",
  "level" : "DEBUG",
  "request_id" : "1857a163-152a-4f3c-ac74-9be0cdd1ca3d",
  "session" : "777a01f4-e6d9-4229-aa96-66d95517a241",
  "method" : "DO_GET"
}
{
  "@timestamp" : "2023-10-11 22:53:10.855",
  "message" : "Call started",
  "thread_name" : "flight-server-default-executor-1",
  "level" : "DEBUG",
  "request_id" : "cdb1928d-7a86-4cb4-8096-1dc8e129f646",
  "session" : "777a01f4-e6d9-4229-aa96-66d95517a241",
  "method" : "DO_ACTION"
}

Through ADBC:

{
  "@timestamp" : "2023-10-11 22:55:03.414",
  "message" : "Call started",
  "thread_name" : "flight-server-default-executor-2",
  "level" : "DEBUG",
  "request_id" : "314a6665-f042-414d-a84c-48e2841d9502",
  "session" : "b47e6ed5-f833-4f53-b877-dd324e8fb82b",
  "method" : "GET_FLIGHT_INFO"
}
{
  "@timestamp" : "2023-10-11 22:55:04.020",
  "message" : "Call started",
  "thread_name" : "flight-server-default-executor-2",
  "level" : "DEBUG",
  "request_id" : "b97a0373-90b1-4c38-adb4-e0738f567cc6",
  "session" : "246bd356-4bfc-4702-934f-369307814de0",
  "method" : "DO_GET"
}
{
  "@timestamp" : "2023-10-11 22:55:04.681",
  "message" : "Call started",
  "thread_name" : "flight-server-default-executor-2",
  "level" : "DEBUG",
  "request_id" : "656729b2-a531-41f6-91e8-4014fe3f4a98",
  "session" : "b47e6ed5-f833-4f53-b877-dd324e8fb82b",
  "method" : "DO_ACTION"
}
{
  "@timestamp" : "2023-10-11 22:55:05.748",
  "message" : "Call started",
  "thread_name" : "flight-server-default-executor-3",
  "level" : "DEBUG",
  "request_id" : "7b1ce66f-df50-4cac-8bad-ae9ab0e9c160",
  "session" : "b47e6ed5-f833-4f53-b877-dd324e8fb82b",
  "method" : "GET_FLIGHT_INFO"
}
{
  "@timestamp" : "2023-10-11 22:55:05.754",
  "message" : "Call started",
  "thread_name" : "flight-server-default-executor-3",
  "level" : "DEBUG",
  "request_id" : "ecda2a81-df07-421a-bac4-2e343141b012",
  "session" : "246bd356-4bfc-4702-934f-369307814de0",
  "method" : "DO_GET"
}
{
  "@timestamp" : "2023-10-11 22:55:06.384",
  "message" : "Call started",
  "thread_name" : "flight-server-default-executor-3",
  "level" : "DEBUG",
  "request_id" : "5e64cf91-67bd-44df-a387-b8bd7423405d",
  "session" : "b47e6ed5-f833-4f53-b877-dd324e8fb82b",
  "method" : "DO_ACTION"
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions