Skip to content

GH-44415: [Release][Ruby] Remove pins from glib section of release verification script#44407

Merged
amoeba merged 1 commit intoapache:mainfrom
amoeba:minor/verify-glib-remove-pins
Oct 15, 2024
Merged

GH-44415: [Release][Ruby] Remove pins from glib section of release verification script#44407
amoeba merged 1 commit intoapache:mainfrom
amoeba:minor/verify-glib-remove-pins

Conversation

@amoeba
Copy link
Copy Markdown
Member

@amoeba amoeba commented Oct 14, 2024

Rationale for this change

We can remove these pins now that conda-forge/glib-feedstock#191 has been closed. I've tested on my own crossbow and will test here momentarily. This effectively reverts #44270 and #44268.

What changes are included in this PR?

Tweaks to release release verification script, specifically removing recently-added pins.

Are these changes tested?

Yes: https://github.com/amoeba/crossbow/actions/runs/11335070956/job/31522511285.

Are there any user-facing changes?

No.

Closes #44415.

@github-actions github-actions bot added the awaiting review Awaiting review label Oct 14, 2024
@amoeba
Copy link
Copy Markdown
Member Author

amoeba commented Oct 14, 2024

@github-actions crossbow submit verify-rc-source-ruby-linux-conda-latest-amd64

@github-actions
Copy link
Copy Markdown

Revision: f755e41

Submitted crossbow builds: ursacomputing/crossbow @ actions-2de9256547

Task Status
verify-rc-source-ruby-linux-conda-latest-amd64 GitHub Actions

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Oct 14, 2024
Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Could you open a new issue for this?
We may want to cherry-pick this to 18.0.0 release branch in the future.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 15, 2024
@amoeba amoeba changed the title MINOR: [Release][Ruby] Remove pins from glib section of release verification script GH-44415: [Release][Ruby] Remove pins from glib section of release verification script Oct 15, 2024
@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #44415 has been automatically assigned in GitHub to PR creator.

@amoeba
Copy link
Copy Markdown
Member Author

amoeba commented Oct 15, 2024

New issue opened, #44415. Thanks @assignUser and @kou.

raulcd pushed a commit that referenced this pull request Oct 15, 2024
…rification script (#44407)

### Rationale for this change

We can remove these pins now that conda-forge/glib-feedstock#191 has been closed. I've tested on my own crossbow and will test here momentarily. This effectively reverts #44270 and #44268.

### What changes are included in this PR?

Tweaks to release release verification script, specifically removing recently-added pins.

### Are these changes tested?

Yes: https://github.com/amoeba/crossbow/actions/runs/11335070956/job/31522511285.

### Are there any user-facing changes?

No.

Closes #44415.
* GitHub Issue: #44415

Authored-by: Bryce Mecum <petridish@gmail.com>
Signed-off-by: Bryce Mecum <petridish@gmail.com>
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 998eca0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Release][Ruby] Remove pins from glib section of release verification script

3 participants