GH-41088: [CI][Crossbow] Fix GitHub Actions workflow syntax error#41091
Merged
kou merged 1 commit intoapache:mainfrom Apr 9, 2024
Merged
GH-41088: [CI][Crossbow] Fix GitHub Actions workflow syntax error#41091kou merged 1 commit intoapache:mainfrom
kou merged 1 commit intoapache:mainfrom
Conversation
We can't use multiple top-level `env:` in workflow. apacheGH-40949 introduced a top-level `env:` by `macros.github_header()`. It broke workflows that already have top-level `env:`.
Member
Author
|
@github-actions crossbow submit verify-rc-source-java-macos-amd64 wheel-macos-* |
|
|
|
Revision: 7c26fed Submitted crossbow builds: ursacomputing/crossbow @ actions-20245b171a
|
Member
Author
|
+1 wheel-macos-* failures are unrelated to this. It's tracked by #41100. |
This was referenced Apr 9, 2024
Closed
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2a2f268. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
raulcd
pushed a commit
that referenced
this pull request
Apr 10, 2024
…1091) ### Rationale for this change We can't use multiple top-level `env:` in workflow. GH-40949 introduced a top-level `env:` by `macros.github_header()`. It broke workflows that already have top-level `env:`. ### What changes are included in this PR? Omit top-level `env:` key and reuse the top-level `env:` key generated by `macros.github_header()` in workflows. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #41088 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…or (apache#41091) ### Rationale for this change We can't use multiple top-level `env:` in workflow. apacheGH-40949 introduced a top-level `env:` by `macros.github_header()`. It broke workflows that already have top-level `env:`. ### What changes are included in this PR? Omit top-level `env:` key and reuse the top-level `env:` key generated by `macros.github_header()` in workflows. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#41088 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We can't use multiple top-level
env:in workflow. GH-40949 introduced a top-levelenv:bymacros.github_header(). It broke workflows that already have top-levelenv:.What changes are included in this PR?
Omit top-level
env:key and reuse the top-levelenv:key generated bymacros.github_header()in workflows.Are these changes tested?
Yes.
Are there any user-facing changes?
No.
verify-rc-source-java-macos-amd64fails with a format error in configs #41088