GH-40221: [C++][CMake] Use arrow/util/config.h.cmake instead of add_definitions()#40222
Merged
kou merged 1 commit intoapache:mainfrom Feb 24, 2024
Merged
GH-40221: [C++][CMake] Use arrow/util/config.h.cmake instead of add_definitions()#40222kou merged 1 commit intoapache:mainfrom
kou merged 1 commit intoapache:mainfrom
Conversation
|
|
Member
Author
|
@github-actions crossbow submit -g cpp -g r -g linux -g python -g r |
This comment was marked as outdated.
This comment was marked as outdated.
… add_definitions() It's easy to maintain.
ac45e33 to
960dbba
Compare
Member
Author
|
@github-actions crossbow submit -g cpp -g r -g linux -g python -g r |
|
Revision: 960dbba Submitted crossbow builds: ursacomputing/crossbow @ actions-5a2aea19a8
|
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit b8fff04. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
mapleFU
pushed a commit
that referenced
this pull request
Mar 18, 2024
….cc (#40625) ### Rationale for this change This is a follow-up of #40222. We need `#include arrow/util/config.h` for `ARROW_WITH_*`. ### What changes are included in this PR? Add missing `#include`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #40621 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: mwish <anmmscs_maple@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It's easy to maintain.
What changes are included in this PR?
Use
#cmakedefineincpp/src/arrow/util/config.h.cmakeand#include "arrow/util/config.h"instead ofadd_definition(...).Are these changes tested?
Yes.
Are there any user-facing changes?
No.