GH-39996: [Archery] Fix Crossbow build on a PR from a fork's main branch#40002
Merged
pitrou merged 1 commit intoapache:mainfrom Feb 12, 2024
Merged
GH-39996: [Archery] Fix Crossbow build on a PR from a fork's main branch#40002pitrou merged 1 commit intoapache:mainfrom
pitrou merged 1 commit intoapache:mainfrom
Conversation
Member
Author
|
@kou This might fix the issue. Also enables more thorough logging in Archery. |
kou
reviewed
Feb 9, 2024
17455a9 to
3dcf932
Compare
…in branch Instead of doing an intermediate bare clone, just fix the locally created branch name when fetching. Amended from PR apache#39997, which wasn't sufficient (the `git fetch` that works for me doesn't seem to work on GHA).
3dcf932 to
d6d661d
Compare
Member
Author
|
The function works locally again, but I'll have to merge for end-to-end testing. |
Member
Author
|
@github-actions crossbow submit conda-clean |
|
Revision: d6d661d Submitted crossbow builds: ursacomputing/crossbow @ actions-7a36663285
|
Member
Author
|
Ok, it finally worked: |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 52e5603. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…in branch (apache#40002) Instead of doing an intermediate bare clone, just fix the locally created branch name when fetching. Amended from PR apache#39997, which wasn't sufficient (the `git fetch` that works for me doesn't seem to work on GHA). * Closes: apache#39996 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of doing an intermediate bare clone, just fix the locally created branch name when fetching.
Amended from PR #39997, which wasn't sufficient (the
git fetchthat works for me doesn't seem to work on GHA).