GH-39996: [Archery] Fix Crossbow build on a PR from a fork's main branch#39997
GH-39996: [Archery] Fix Crossbow build on a PR from a fork's main branch#39997pitrou merged 1 commit intoapache:mainfrom
Conversation
|
|
|
I've checked that |
|
How about adding the following to this PR only for testing? diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml
index 4892767324..c8d3bdd1ec 100644
--- a/.github/workflows/dev.yml
+++ b/.github/workflows/dev.yml
@@ -113,3 +113,25 @@ jobs:
- name: Run Merge Script Test
shell: bash
run: pytest -v dev/test_merge_arrow_pr.py
+
+ crossbow:
+ name: Crossbow
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Arrow
+ uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
+ with:
+ path: arrow
+ # fetch the tags for version number generation
+ fetch-depth: 0
+ - name: Set up Python
+ uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
+ with:
+ python-version: 3.8
+ - name: Install Archery and Crossbow dependencies
+ run: pip install -e arrow/dev/archery[bot]
+ - name: Handle GitHub comment event
+ env:
+ ARROW_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ archery crossbow submit ...Or I think that we can merge this to main and try because you've already checked this on your local. |
|
Ah, thanks, I will add your suggestion. |
|
Your suggestion didn't work. We would need to call |
|
Ah, the changed code is for How about merging this? |
6d0b2d6 to
eb21b9f
Compare
Fair enough, let's do it. |
|
@github-actions crossbow submit conda-clean |
|
Revision: eb21b9f Submitted crossbow builds: ursacomputing/crossbow @ actions-cbba493874
|
|
Ok, so this didn't work on the original PR: |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 30f6fdb. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 21 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…in branch Instead of doing an intermediate bare clone, just fix the locally created branch name when fetching. Amended from PR apache#39997, which wasn't sufficient (the `git fetch` that works for me doesn't seem to work on GHA).
…nch (#40002) Instead of doing an intermediate bare clone, just fix the locally created branch name when fetching. Amended from PR #39997, which wasn't sufficient (the `git fetch` that works for me doesn't seem to work on GHA). * Closes: #39996 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
…in branch (apache#39997) ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? * Closes: apache#39996 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
…in branch (apache#40002) Instead of doing an intermediate bare clone, just fix the locally created branch name when fetching. Amended from PR apache#39997, which wasn't sufficient (the `git fetch` that works for me doesn't seem to work on GHA). * Closes: apache#39996 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?