cc @pitrou

If things go well, we should be seeing the ASAN failure as described in #39976 somewhere in CI job. This is expected as we are strengthening the ASAN check so hidden legacy failures are exposed.

@github-actions crossbow submit -g cpp

I've cleaned up the failed Crossbow requests :-)

The legacy ASAN failure will be gone once #39994 goes in.

I've rebased, hopefully CI wil be green now.

@github-actions crossbow submit -g cpp

Revision: b9ff2f3

Submitted crossbow builds: ursacomputing/crossbow @ actions-1f71ea13ea

Task	Status
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp
test-debian-11-cpp-amd64
test-debian-11-cpp-i386
test-fedora-38-cpp
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-minimal-with-formats
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-no-threading

I've rebased, hopefully CI wil be green now.

Thank you for rebasing.

Praying for CI now.

You can stop praying now :-)

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a946214.

There were 4 benchmark results indicating a performance regression:

• Commit Run on ec2-m5-4xlarge-us-east-2 at 2024-02-08 18:55:06Z
  • tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-01, scale_factor=10
  • tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-03, scale_factor=10
• and 2 more (see the report linked below)

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.