GH-39976: [C++] Fix out-of-line data size calculation in BinaryViewBuilder::AppendArraySlice#39994
Merged
pitrou merged 3 commits intoapache:mainfrom Feb 8, 2024
Merged
GH-39976: [C++] Fix out-of-line data size calculation in BinaryViewBuilder::AppendArraySlice#39994pitrou merged 3 commits intoapache:mainfrom
pitrou merged 3 commits intoapache:mainfrom
Conversation
Contributor
Author
pitrou
requested changes
Feb 8, 2024
Member
pitrou
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing this. Just one suggestion below.
pitrou
approved these changes
Feb 8, 2024
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 98c4225. There were 5 benchmark results indicating a performance regression:
The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…ViewBuilder::AppendArraySlice (apache#39994) ### Rationale for this change Fix the bug in `BinaryViewBuilder::AppendArraySlice` that, when calculating out-of-line data size, the array is wrongly iterated. ### What changes are included in this PR? Fix and UT. ### Are these changes tested? UT included. ### Are there any user-facing changes? No. * Closes: apache#39976 Authored-by: Ruoxi Sun <zanmato1984@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
raulcd
pushed a commit
that referenced
this pull request
Feb 20, 2024
…ilder::AppendArraySlice (#39994) ### Rationale for this change Fix the bug in `BinaryViewBuilder::AppendArraySlice` that, when calculating out-of-line data size, the array is wrongly iterated. ### What changes are included in this PR? Fix and UT. ### Are these changes tested? UT included. ### Are there any user-facing changes? No. * Closes: #39976 Authored-by: Ruoxi Sun <zanmato1984@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix the bug in
BinaryViewBuilder::AppendArraySlicethat, when calculating out-of-line data size, the array is wrongly iterated.What changes are included in this PR?
Fix and UT.
Are these changes tested?
UT included.
Are there any user-facing changes?
No.
TestArray.TestAppendArraySlice#39976