GH-39823: [C++] Allow building cpp/src/arrow/**/*.cc without waiting bundled libraries by kou · Pull Request #39824 · apache/arrow

kou · 2024-01-29T08:34:23Z

Rationale for this change

If we can build most of cpp/src/arrow/**/*.cc before all bundled libraries are built, we can reduce build time.

What changes are included in this PR?

Remove the toolchain internal CMake target
Remove ARROW_SHARED_LINK_LIBS
Remove ARROW_STATIC_LINK_LIBS
Move the following variables to cpp/src/arrow/CMakeLists.txt
- ARROW_SHARED_PRIVATE_LINK_LIBS
- ARROW_SHARED_INSTALL_INTERFACE_LIBS
- ARROW_STATIC_INSTALL_INTERFACE_LIBS
- ARROW_TEST_LINK_TOOLCHAIN
- ARROW_TEST_SHARED_LINK_LIBS
- ARROW_TEST_STATIC_LINK_LIBS
- ARROW_SYSTEM_LINK_LIBS
Add internal OBJECT libraries that have minimal dependencies
Remove unused cpp/src/arrow/util/benchmark_main.cc

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

kou · 2024-01-29T08:34:34Z

@github-actions crossbow submit -g cpp

github-actions · 2024-01-29T08:34:50Z

⚠️ GitHub issue #39823 has been automatically assigned in GitHub to PR creator.

cpp/src/arrow/compute/kernels/CMakeLists.txt

kou · 2024-01-30T00:27:43Z

@github-actions crossbow submit -g cpp

kou · 2024-01-30T03:49:17Z

@github-actions crossbow submit -g cpp

kou · 2024-01-30T05:48:19Z

cpp/src/arrow/**/*.cc are built before jemalloc is built:

https://github.com/apache/arrow/actions/runs/7705131604/job/20998591461?pr=39824#step:6:1465

[48/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/array_primitive.cc.o
[49/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/array_base.cc.o
[50/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/array_nested.cc.o
[51/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/array_run_end.cc.o
[52/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/builder_adaptive.cc.o
[53/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/builder_decimal.cc.o
[54/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/builder_binary.cc.o
[55/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/array_dict.cc.o
[56/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/builder_base.cc.o
[57/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/builder_run_end.cc.o
[58/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/builder_primitive.cc.o
[59/1143] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/builder_nested.cc.o
[60/1143] Performing configure step for 'jemalloc_ep'

pitrou · 2024-01-31T13:34:09Z

cpp/src/arrow/CMakeLists.txt

Can we perhaps use pragmas inside io_util.cc to avoid this?

Yes, we can do it.
I'll add a change for it.

I removed this and no CI weren't failed. So it seems that we don't need this now.

pitrou · 2024-01-31T13:43:40Z

cpp/src/arrow/acero/CMakeLists.txt

Why can't this be added to add_arrow_acero_test instead of repeating it in each test declaration?

We can do it by:

diff --git a/cpp/src/arrow/acero/CMakeLists.txt b/cpp/src/arrow/acero/CMakeLists.txt index 36afad4972..7f40d1bd19 100644 --- a/cpp/src/arrow/acero/CMakeLists.txt +++ b/cpp/src/arrow/acero/CMakeLists.txt @@ -139,10 +139,9 @@ function(add_arrow_acero_test REL_TEST_NAME) set(PREFIX "arrow-acero") endif() + set(EXTRA_LINK_LIBS ${ARROW_ACERO_TEST_LINK_LIBS}) if(ARG_EXTRA_LINK_LIBS) - set(EXTRA_LINK_LIBS ${ARG_EXTRA_LINK_LIBS}) - else() - set(EXTRA_LINK_LIBS ${ARROW_ACERO_TEST_LINK_LIBS}) + list(APPEND EXTRA_LINK_LIBS ${ARG_EXTRA_LINK_LIBS}) endif() if(ARG_LABELS)

but we use "override" instead of "append" when we specify a value explicitly in our functions.
So I used the same behavior for consistency here.

How about defining a variable to remove the duplication and keep consistency?

diff --git a/cpp/src/arrow/acero/CMakeLists.txt b/cpp/src/arrow/acero/CMakeLists.txt index 36afad4972..2b1683b99a 100644 --- a/cpp/src/arrow/acero/CMakeLists.txt +++ b/cpp/src/arrow/acero/CMakeLists.txt @@ -161,51 +161,47 @@ function(add_arrow_acero_test REL_TEST_NAME) ${ARG_UNPARSED_ARGUMENTS}) endfunction() +set(ARROW_ACERO_NODE_TEST_LINK_LIBS ${ARROW_ACERO_TEST_LINK_LIBS}) if(ARROW_TESTING) add_library(arrow_acero_test_nodes OBJECT test_nodes.cc) target_link_libraries(arrow_acero_test_nodes PRIVATE ${ARROW_ACERO_TEST_LINK_LIBS}) if(ARROW_WITH_OPENTELEMETRY) target_link_libraries(arrow_acero_test_nodes PRIVATE ${ARROW_OPENTELEMETRY_LIBS}) endif() + list(APPEND ARROW_ACERO_NODE_TEST_LINK_LIBS arrow_acero_test_nodes) endif() add_arrow_acero_test(plan_test SOURCES plan_test.cc test_nodes_test.cc EXTRA_LINK_LIBS - ${ARROW_ACERO_TEST_LINK_LIBS} - arrow_acero_test_nodes) + ${ARROW_ACERO_NODE_TEST_LINK_LIBS}) add_arrow_acero_test(source_node_test SOURCES source_node_test.cc EXTRA_LINK_LIBS - ${ARROW_ACERO_TEST_LINK_LIBS} - arrow_acero_test_nodes) + ${ARROW_ACERO_NODE_TEST_LINK_LIBS}) add_arrow_acero_test(fetch_node_test SOURCES fetch_node_test.cc EXTRA_LINK_LIBS - ${ARROW_ACERO_TEST_LINK_LIBS} - arrow_acero_test_nodes) + ${ARROW_ACERO_NODE_TEST_LINK_LIBS}) add_arrow_acero_test(order_by_node_test SOURCES order_by_node_test.cc EXTRA_LINK_LIBS - ${ARROW_ACERO_TEST_LINK_LIBS} - arrow_acero_test_nodes) + ${ARROW_ACERO_NODE_TEST_LINK_LIBS}) add_arrow_acero_test(hash_join_node_test SOURCES hash_join_node_test.cc bloom_filter_test.cc EXTRA_LINK_LIBS - ${ARROW_ACERO_TEST_LINK_LIBS} - arrow_acero_test_nodes) + ${ARROW_ACERO_NODE_TEST_LINK_LIBS}) add_arrow_acero_test(pivot_longer_node_test SOURCES pivot_longer_node_test.cc EXTRA_LINK_LIBS - ${ARROW_ACERO_TEST_LINK_LIBS} - arrow_acero_test_nodes) + ${ARROW_ACERO_NODE_TEST_LINK_LIBS}) # asof_join_node and sorted_merge_node use std::thread internally # and doesn't use ThreadPool so it will @@ -215,14 +211,12 @@ if(ARROW_ENABLE_THREADING) SOURCES asof_join_node_test.cc EXTRA_LINK_LIBS - ${ARROW_ACERO_TEST_LINK_LIBS} - arrow_acero_test_nodes) + ${ARROW_ACERO_NODE_TEST_LINK_LIBS}) add_arrow_acero_test(sorted_merge_node_test SOURCES sorted_merge_node_test.cc EXTRA_LINK_LIBS - ${ARROW_ACERO_TEST_LINK_LIBS} - arrow_acero_test_nodes) + ${ARROW_ACERO_NODE_TEST_LINK_LIBS}) endif() add_arrow_acero_test(tpch_node_test SOURCES tpch_node_test.cc)

Well, can arrow_acero_test_nodes just be linked into every Acero test?

We can do it. Some tests don't need it. So it's just not used.

kou · 2024-02-28T14:59:29Z

Oh, I don't know why but the AppVeyor failures were fixed...: https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/49291292?fullLog=true

It seems that using gmock for all tests 95eb410 is related.

I haven't touched _CRT_SECURE_NO_WARNINGS related build options yet. But we can confirm that _CRT_SECURE_NO_WARNINGS is already used by the above verbose AppVeyor log.

kou · 2024-02-28T15:01:15Z

@github-actions crossbow submit -g cpp -g r -g linux -g python -g r

github-actions · 2024-02-28T15:05:55Z

Revision: 7203b8a

Submitted crossbow builds: ursacomputing/crossbow @ actions-255108a88a

Task	Status
almalinux-8-amd64
almalinux-8-arm64
almalinux-9-amd64
almalinux-9-arm64
amazon-linux-2023-amd64
amazon-linux-2023-arm64
centos-7-amd64
centos-8-stream-amd64
centos-8-stream-arm64
centos-9-stream-amd64
centos-9-stream-arm64
debian-bookworm-amd64
debian-bookworm-arm64
debian-bullseye-amd64
debian-bullseye-arm64
debian-trixie-amd64
debian-trixie-arm64
r-binary-packages
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-conda-python-3.10
test-conda-python-3.10-cython2
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest
test-conda-python-3.10-pandas-nightly
test-conda-python-3.10-spark-v3.5.0
test-conda-python-3.10-substrait
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-upstream_devel
test-conda-python-3.11-spark-master
test-conda-python-3.12
test-conda-python-3.8
test-conda-python-3.8-pandas-1.0
test-conda-python-3.8-spark-v3.5.0
test-conda-python-3.9
test-conda-python-3.9-pandas-latest
test-cuda-cpp
test-cuda-python
test-debian-11-cpp-amd64
test-debian-11-cpp-i386
test-debian-11-python-3-amd64
test-debian-11-python-3-i386
test-fedora-39-cpp
test-fedora-39-python-3
test-fedora-r-clang-sanitizer
test-r-arrow-backwards-compatibility
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-library-r-base-latest
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-valgrind
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-debian-gcc-release-custom-ccache
test-r-rhub-ubuntu-gcc-release-latest
test-r-rstudio-r-base-4.1-opensuse153
test-r-rstudio-r-base-4.2-centos7-devtoolset-8
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-minimal-with-formats
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-20.04-python-3
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-22.04-python-3
test-ubuntu-r-sanitizer
ubuntu-focal-amd64
ubuntu-focal-arm64
ubuntu-jammy-amd64
ubuntu-jammy-arm64
ubuntu-noble-amd64
ubuntu-noble-arm64

pitrou · 2024-02-28T15:20:03Z

It seems that using gmock for all tests 95eb410 is related.

I haven't touched _CRT_SECURE_NO_WARNINGS related build options yet. But we can confirm that _CRT_SECURE_NO_WARNINGS is already used by the above verbose AppVeyor log.

That's weird. Perhaps linking to GMock automatically enables it?

pitrou · 2024-02-28T15:37:14Z

@github-actions crossbow submit -g wheel

github-actions · 2024-02-28T15:40:01Z

Revision: 7203b8a

Submitted crossbow builds: ursacomputing/crossbow @ actions-9f09457a19

Task	Status
wheel-macos-big-sur-cp310-arm64
wheel-macos-big-sur-cp311-arm64
wheel-macos-big-sur-cp312-arm64
wheel-macos-big-sur-cp38-arm64
wheel-macos-big-sur-cp39-arm64
wheel-macos-catalina-cp310-amd64
wheel-macos-catalina-cp311-amd64
wheel-macos-catalina-cp312-amd64
wheel-macos-catalina-cp38-amd64
wheel-macos-catalina-cp39-amd64
wheel-manylinux-2-28-cp310-amd64
wheel-manylinux-2-28-cp310-arm64
wheel-manylinux-2-28-cp311-amd64
wheel-manylinux-2-28-cp311-arm64
wheel-manylinux-2-28-cp312-amd64
wheel-manylinux-2-28-cp312-arm64
wheel-manylinux-2-28-cp38-amd64
wheel-manylinux-2-28-cp38-arm64
wheel-manylinux-2-28-cp39-amd64
wheel-manylinux-2-28-cp39-arm64
wheel-manylinux-2014-cp310-amd64
wheel-manylinux-2014-cp310-arm64
wheel-manylinux-2014-cp311-amd64
wheel-manylinux-2014-cp311-arm64
wheel-manylinux-2014-cp312-amd64
wheel-manylinux-2014-cp312-arm64
wheel-manylinux-2014-cp38-amd64
wheel-manylinux-2014-cp38-arm64
wheel-manylinux-2014-cp39-amd64
wheel-manylinux-2014-cp39-arm64
wheel-windows-cp310-amd64
wheel-windows-cp311-amd64
wheel-windows-cp312-amd64
wheel-windows-cp38-amd64
wheel-windows-cp39-amd64

pitrou

LGTM, but let's make sure CI is ok

kou · 2024-02-29T00:43:00Z

Perhaps linking to GMock automatically enables it?

Maybe?

All wheel jobs are green. I'll merge this.

conbench-apache-arrow · 2024-02-29T09:45:32Z

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 909f6f9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

…ic (#40433) ### Rationale for this change `libarrow.a` uses `std::mutex` and so on. So we need to link to `Threads::Threads`. But #39824 dropped it accidentally. ### What changes are included in this PR? Add unexpectedly dropped `Threads::Threads` dependency to `arrow_static` again. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #40432 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>

### Rationale for this change ```text LINK : warning LNK4217: symbol 'uriEscapeExA' defined in 'arrow_static.lib(unity_0_c.c.obj)' is imported by 'arrow_static.lib(unity_5_cxx.cxx.obj)' in function '"class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl arrow::internal::UriEscape(class std::basic_string_view<char,struct std::char_traits<char> >)" (?UriEscape@ internal@ arrow@@ YA?AV?$basic_string@ DU?$char_traits@ D@ std@@ V?$allocator@ D@ 2@@ std@@ V?$basic_string_view@ DU?$char_traits@ D@ std@@@ 4@@ Z)' LINK : warning LNK4217: symbol 'uriUnescapeInPlaceA' defined in 'arrow_static.lib(unity_0_c.c.obj)' is imported by 'arrow_static.lib(unity_5_cxx.cxx.obj)' in function '"class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl arrow::internal::UriUnescape(class std::basic_string_view<char,struct std::char_traits<char> >)" (?UriUnescape@ internal@ arrow@@ YA?AV?$basic_string@ DU?$char_traits@ D@ std@@ V?$allocator@ D@ 2@@ std@@ V?$basic_string_view@ DU?$char_traits@ D@ std@@@ 4@@ Z)' LINK : warning LNK4217: symbol 'uriWindowsFilenameToUriStringA' defined in 'arrow_static.lib(unity_0_c.c.obj)' is imported by 'arrow_static.lib(unity_5_cxx.cxx.obj)' in function '"class arrow::Result<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > __cdecl arrow::internal::UriFromAbsolutePath(class std::basic_string_view<char,struct std::char_traits<char> >)" (?UriFromAbsolutePath@ internal@ arrow@@ YA?AV?$Result@ V?$basic_string@ DU?$char_traits@ D@ std@@ V?$allocator@ D@ 2@@ std@@@ 2@ V?$basic_string_view@ DU?$char_traits@ D@ std@@@ std@@@ Z)' arrow_static.lib(unity_5_cxx.cxx.obj) : error LNK2019: unresolved external symbol __imp_uriParseSingleUriExA referenced in function "public: class arrow::Status __cdecl arrow::internal::Uri::Parse(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?Parse@ Uri@ internal@ arrow@@ QEAA?AVStatus@ 3@ AEBV?$basic_string@ DU?$char_traits@ D@ std@@ V?$allocator@ D@ 2@@ std@@@ Z) arrow_static.lib(unity_5_cxx.cxx.obj) : error LNK2019: unresolved external symbol __imp_uriFreeUriMembersA referenced in function "public: __cdecl arrow::internal::Uri::Impl::~Impl(void)" (??1Impl@ Uri@ internal@ arrow@@ QEAA@ XZ) arrow_static.lib(unity_5_cxx.cxx.obj) : error LNK2019: unresolved external symbol __imp_uriDissectQueryMallocA referenced in function "public: class arrow::Result<class std::vector<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > > > > __cdecl arrow::internal::Uri::query_items(void)const " (?query_items@ Uri@ internal@ arrow@@ QEBA?AV?$Result@ V?$vector@ U?$pair@ V?$basic_string@ DU?$char_traits@ D@ std@@ V?$allocator@ D@ 2@@ std@@ V12@@ std@@ V?$allocator@ U?$pair@ V?$basic_string@ DU?$char_traits@ D@ std@@ V?$allocator@ D@ 2@@ std@@ V12@@ std@@@ 2@@ std@@@ 3@ XZ) arrow_static.lib(unity_5_cxx.cxx.obj) : error LNK2019: unresolved external symbol __imp_uriFreeQueryListA referenced in function "public: class arrow::Result<class std::vector<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > >,class std::allocator<struct std::pair<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > > > > __cdecl arrow::internal::Uri::query_items(void)const " (?query_items@ Uri@ internal@ arrow@@ QEBA?AV?$Result@ V?$vector@ U?$pair@ V?$basic_string@ DU?$char_traits@ D@ std@@ V?$allocator@ D@ 2@@ std@@ V12@@ std@@ V?$allocator@ U?$pair@ V?$basic_string@ DU?$char_traits@ D@ std@@ V?$allocator@ D@ 2@@ std@@ V12@@ std@@@ 2@@ std@@@ 3@ XZ) aws-c-io.lib(secure_channel_tls_handler.c.obj) : error LNK2019: unresolved external symbol __imp_CertFreeCertificateContext referenced in function s_ctx_new aws-c-io.lib(windows_pki_utils.c.obj) : error LNK2001: unresolved external symbol __imp_CertFreeCertificateContext aws-c-io.lib(secure_channel_tls_handler.c.obj) : error LNK2019: unresolved external symbol __imp_CertCreateCertificateChainEngine referenced in function s_manually_verify_peer_cert aws-c-io.lib(secure_channel_tls_handler.c.obj) : error LNK2019: unresolved external symbol __imp_CertFreeCertificateChainEngine referenced in function s_manually_verify_peer_cert aws-c-io.lib(secure_channel_tls_handler.c.obj) : error LNK2019: unresolved external symbol __imp_CertGetCertificateChain referenced in function s_manually_verify_peer_cert aws-c-io.lib(secure_channel_tls_handler.c.obj) : error LNK2019: unresolved external symbol __imp_CertFreeCertificateChain referenced in function s_manually_verify_peer_cert aws-c-io.lib(secure_channel_tls_handler.c.obj) : error LNK2019: unresolved external symbol __imp_CertVerifyCertificateChainPolicy referenced in function s_manually_verify_peer_cert aws-c-io.lib(windows_pki_utils.c.obj) : error LNK2019: unresolved external symbol __imp_CryptDecodeObjectEx referenced in function aws_import_key_pair_to_cert_context aws-c-io.lib(windows_pki_utils.c.obj) : error LNK2019: unresolved external symbol __imp_CertOpenStore referenced in function aws_import_key_pair_to_cert_context aws-c-io.lib(windows_pki_utils.c.obj) : error LNK2019: unresolved external symbol __imp_CertCloseStore referenced in function aws_close_cert_store aws-c-io.lib(windows_pki_utils.c.obj) : error LNK2019: unresolved external symbol __imp_CertFindCertificateInStore referenced in function aws_load_cert_from_system_cert_store aws-c-io.lib(windows_pki_utils.c.obj) : error LNK2019: unresolved external symbol __imp_CertSetCertificateContextProperty referenced in function aws_import_key_pair_to_cert_context aws-c-io.lib(windows_pki_utils.c.obj) : error LNK2019: unresolved external symbol __imp_CertAddCertificateContextToStore referenced in function aws_import_key_pair_to_cert_context aws-c-io.lib(windows_pki_utils.c.obj) : error LNK2019: unresolved external symbol __imp_CryptQueryObject referenced in function aws_import_key_pair_to_cert_context aws-c-io.lib(windows_pki_utils.c.obj) : error LNK2019: unresolved external symbol __imp_CryptStringToBinaryA referenced in function aws_load_cert_from_system_cert_store ``` ### What changes are included in this PR? * Add missing `URI_STATIC_BUILD` macro definition that was removed by #39824 accidentally. * Add missing `crypt32.lib` dependency to `aws-c-io`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #40445 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>

kou requested review from lidavidm, westonpace and wgtmac as code owners January 29, 2024 08:34

kou mentioned this pull request Jan 29, 2024

[C++] Remove serial dependency on jemalloc #39559

Closed

github-actions bot added Component: Parquet Component: C++ Component: FlightRPC Component: Gandiva awaiting committer review Awaiting committer review labels Jan 29, 2024

This comment was marked as outdated.

Sign in to view

wgtmac reviewed Jan 29, 2024

View reviewed changes

cpp/src/arrow/compute/kernels/CMakeLists.txt Outdated Show resolved Hide resolved

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 29, 2024

kou force-pushed the cpp-cmake-thirdparty-parallel branch from 3d69f11 to 6ac50a9 Compare January 30, 2024 00:27

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 30, 2024

This comment was marked as outdated.

Sign in to view

kou force-pushed the cpp-cmake-thirdparty-parallel branch from 6ac50a9 to 9e0a933 Compare January 30, 2024 01:49

This comment was marked as outdated.

Sign in to view

kou force-pushed the cpp-cmake-thirdparty-parallel branch 2 times, most recently from 0155e17 to dcf95db Compare January 31, 2024 07:58

pitrou reviewed Jan 31, 2024

View reviewed changes

kou force-pushed the cpp-cmake-thirdparty-parallel branch from dcf95db to 57cde0c Compare February 1, 2024 00:48

github-actions bot removed the awaiting change review Awaiting change review label Feb 1, 2024

kou force-pushed the cpp-cmake-thirdparty-parallel branch from a9437fc to 811674a Compare February 28, 2024 13:36

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 28, 2024

appveyor: make verbose

5663db2

kou requested review from assignUser and raulcd as code owners February 28, 2024 13:40

Revert --verbose

7203b8a

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Feb 28, 2024

pitrou approved these changes Feb 28, 2024

View reviewed changes

kou merged commit 909f6f9 into apache:main Feb 29, 2024

kou deleted the cpp-cmake-thirdparty-parallel branch February 29, 2024 00:44

kou removed the awaiting changes Awaiting changes label Feb 29, 2024

kou mentioned this pull request Mar 4, 2024

[C++][CMake] cpp/src/arrow/util/logging.cc misses glog::glog dependency #40331

Closed

This was referenced Mar 9, 2024

[C++] Threads::Threads dependency is missing for static linking #40432

Closed

GH-40432: [C++] Add missing Threads::Threads dependency to arrow_static #40433

Merged

kou mentioned this pull request Mar 10, 2024

GH-40445: [C++] Fix static build on Windows #40446

Merged

kou mentioned this pull request May 14, 2024

[CI][Python] Windows wheel builds build both static and shared libraries of Arrow C++ #41652

Closed

kou mentioned this pull request Jun 30, 2025

GH-46915: [C++][Compute] Initialize Compute kernels on benchmarks that require extra kernels #46922

Merged

Conversation

kou commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

kou commented Jan 29, 2024

Uh oh!

github-actions bot commented Jan 29, 2024

Uh oh!

This comment was marked as outdated.

Uh oh!

kou commented Jan 30, 2024

Uh oh!

This comment was marked as outdated.

kou commented Jan 30, 2024

Uh oh!

This comment was marked as outdated.

kou commented Jan 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kou commented Feb 28, 2024

Uh oh!

kou commented Feb 28, 2024

Uh oh!

github-actions bot commented Feb 28, 2024

Uh oh!

pitrou commented Feb 28, 2024

Uh oh!

pitrou commented Feb 28, 2024

Uh oh!

github-actions bot commented Feb 28, 2024

Uh oh!

pitrou left a comment

Choose a reason for hiding this comment

Uh oh!

kou commented Feb 29, 2024

Uh oh!

conbench-apache-arrow bot commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kou commented Jan 29, 2024 •

edited

Loading

kou commented Jan 30, 2024 •

edited

Loading