GH-40432: [C++] Add missing Threads::Threads dependency to arrow_static#40433
Merged
kou merged 1 commit intoapache:mainfrom Mar 9, 2024
Merged
GH-40432: [C++] Add missing Threads::Threads dependency to arrow_static#40433kou merged 1 commit intoapache:mainfrom
kou merged 1 commit intoapache:mainfrom
Conversation
Member
Author
|
@github-actions crossbow submit example-cpp-* -g cpp |
|
|
|
Revision: 68fbcb4 Submitted crossbow builds: ursacomputing/crossbow @ actions-986a8c0b5e
|
Member
Author
|
+1 |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 6a7a6ee. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 15 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
libarrow.ausesstd::mutexand so on. So we need to link toThreads::Threads. But #39824 dropped it accidentally.What changes are included in this PR?
Add unexpectedly dropped
Threads::Threadsdependency toarrow_staticagain.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.