GH-39706: [Archery] Fix benchmark diff subcommand#39733
Merged
pitrou merged 1 commit intoapache:mainfrom Jan 22, 2024
Merged
Conversation
Member
Author
|
@kou @assignUser Does one of you want to take a quick look? |
assignUser
approved these changes
Jan 22, 2024
Member
assignUser
left a comment
There was a problem hiding this comment.
With the caveat that I am not too familiar with the deeper benchmark bits of archery this looks sensible :)
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 92c5afe. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### What changes are included in this PR? This fixes a regression introduced in apacheGH-39303. ### Are these changes tested? Only manually. ### Are there any user-facing changes? No. * Closes: apache#39706 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
This fixes a regression introduced in GH-39303.
Are these changes tested?
Only manually.
Are there any user-facing changes?
No.
archery benchmark diffwith JSON inputs broken #39706