-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Archery] archery benchmark diff with JSON inputs broken #39706
Copy link
Copy link
Closed
Description
Describe the bug, including details regarding any error messages, version, and platform.
$ archery benchmark diff sort-after.json sort-before.json
Traceback (most recent call last):
File "/home/antoine/mambaforge/envs/pyarrow/bin/archery", line 33, in <module>
sys.exit(load_entry_point('archery', 'console_scripts', 'archery')())
File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
return self.main(*args, **kwargs)
File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 1688, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/core.py", line 783, in invoke
return __callback(*args, **kwargs)
File "/home/antoine/mambaforge/envs/pyarrow/lib/python3.10/site-packages/click/decorators.py", line 33, in new_func
return f(get_current_context(), *args, **kwargs)
File "/home/antoine/arrow/dev/dev/archery/archery/cli.py", line 628, in benchmark_diff
conf = CppBenchmarkRunner.default_configuration(
File "/home/antoine/arrow/dev/dev/archery/archery/benchmark/runner.py", line 120, in default_configuration
return CppConfiguration(
TypeError: CppConfiguration.__init__() got an unexpected keyword argument 'cpp_benchmark_extras'This is probably because of #39324
Component(s)
Archery, Benchmarking
Reactions are currently unavailable