GH-38039: [C++][Parquet] Fix segfault getting compression level for a Parquet column#38025
Merged
pitrou merged 2 commits intoapache:mainfrom Oct 5, 2023
Merged
Conversation
Member
|
Would you mind create an issue for this? I guess this is not a "minor" fix for arrow github manangement |
|
|
pitrou
approved these changes
Oct 5, 2023
Member
pitrou
left a comment
There was a problem hiding this comment.
+1, thanks a lot @adamreeve . I created an issue for this and will merge.
Contributor
Author
|
Thanks for making the issue @pitrou, and apologies for not making one to start with, I should have read the contributing doc more closely |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 0fbfffb. There were 10 benchmark results indicating a performance regression:
The full Conbench report has more details. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
… for a Parquet column (apache#38025) ### Rationale for this change After the changes in apache#35886, getting the compression level for a Parquet column segfaults if the compression level or other options weren't previously set ### What changes are included in this PR? Adds a null check on the codec options of the column properties before trying to access the compression level. ### Are these changes tested? Yes, I added a unit test. ### Are there any user-facing changes? This fixes a regression added after 13.0.0 so isn't a user-facing fix * Closes: apache#38039 Authored-by: Adam Reeve <adreeve@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
… for a Parquet column (apache#38025) ### Rationale for this change After the changes in apache#35886, getting the compression level for a Parquet column segfaults if the compression level or other options weren't previously set ### What changes are included in this PR? Adds a null check on the codec options of the column properties before trying to access the compression level. ### Are these changes tested? Yes, I added a unit test. ### Are there any user-facing changes? This fixes a regression added after 13.0.0 so isn't a user-facing fix * Closes: apache#38039 Authored-by: Adam Reeve <adreeve@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
After the changes in #35886, getting the compression level for a Parquet column segfaults if the compression level or other options weren't previously set
What changes are included in this PR?
Adds a null check on the codec options of the column properties before trying to access the compression level.
Are these changes tested?
Yes, I added a unit test.
Are there any user-facing changes?
This fixes a regression added after 13.0.0 so isn't a user-facing fix