GH-36568: [Go] Include Timestamp Zone in ValueStr#36569
Merged
zeroshade merged 2 commits intoapache:mainfrom Jul 10, 2023
Merged
GH-36568: [Go] Include Timestamp Zone in ValueStr#36569zeroshade merged 2 commits intoapache:mainfrom
zeroshade merged 2 commits intoapache:mainfrom
Conversation
|
|
lidavidm
reviewed
Jul 8, 2023
Member
lidavidm
left a comment
There was a problem hiding this comment.
Is there a test case we can add?
Member
Author
|
@lidavidm test case added |
lidavidm
approved these changes
Jul 10, 2023
lidavidm
pushed a commit
to apache/arrow-adbc
that referenced
this pull request
Jul 11, 2023
…amp handling (#889) Currently relies on apache/arrow#36569 being merged first.
raulcd
pushed a commit
that referenced
this pull request
Jul 11, 2023
### Rationale for this change While trying to fix an issue with Snowflake ADBC timestamp handling, I came across this as part of the problem. ### What changes are included in this PR? Adds the timezone string indicator to the output of `ValueStr` for a timestamp array. * Closes: #36568 Authored-by: Matt Topol <zotthewizard@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
This was referenced Jul 17, 2023
Merged
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 70f4476. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
lidavidm
pushed a commit
to adbc-drivers/snowflake
that referenced
this pull request
Oct 9, 2025
Currently relies on apache/arrow#36569 being merged first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While trying to fix an issue with Snowflake ADBC timestamp handling, I came across this as part of the problem.
What changes are included in this PR?
Adds the timezone string indicator to the output of
ValueStrfor a timestamp array.