fix(go/adbc/driver/snowflake): Fix integration tests by fixing timestamp handling#889
Merged
lidavidm merged 3 commits intoapache:mainfrom Jul 11, 2023
Merged
Conversation
lidavidm
reviewed
Jul 8, 2023
Comment on lines
+156
to
+158
| return fmt.Sprintf("timestamp_ntz(%d)", prec) | ||
| } | ||
| return fmt.Sprintf("timestamp_ltz(%d)", prec) | ||
| return fmt.Sprintf("timestamp_tz(%d)", prec) |
| dt := &arrow.TimestampType{Unit: arrow.Nanosecond} | ||
| // we convert each value to UTC since we have timezone information | ||
| // with the data that lets us do so. | ||
| dt := &arrow.TimestampType{TimeZone: "UTC", Unit: arrow.TimeUnit(srcMeta.Scale / 3)} |
Member
There was a problem hiding this comment.
Can we bank on the scale being consistent like that?
Member
Author
There was a problem hiding this comment.
as far as I can tell from testing and the docs on the data types, it seems so.
lidavidm
approved these changes
Jul 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently relies on apache/arrow#36569 being merged first.