Skip to content

GH-28497: [C++][Compute] Add quotient and modulo kernels #11116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
edponce wants to merge 4 commits into from
Closed

GH-28497: [C++][Compute] Add quotient and modulo kernels #11116

edponce wants to merge 4 commits into from

Conversation

@edponce
Copy link
Contributor

@edponce edponce commented Sep 9, 2021 •
edited by github-actions bot
Loading

This PR adds compute functions "floor_divide" and "remainder".

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

https://issues.apache.org/jira/browse/ARROW-12755

@pitrou
Copy link
Member

pitrou commented Nov 10, 2021

@edponce Are you willing to pursue this?

@edponce
Copy link
Contributor Author

edponce commented Nov 10, 2021 •
edited
Loading

@pitrou I will complete this PR in the next couple of days. Basically, plan on finishing divmod PR first and then make these individual kernels call divmod.

I got a stuck when needed to output a struct for div and mod pairs, but I think I can solve it now.

@ianmcook
Copy link
Member

ianmcook commented Jun 2, 2022

@edponce could you please make it a priority to complete this PR, or see if someone else can take it over? Thanks.

@edponce edponce force-pushed the ARROW-12755-Compute-Add-quotient-and-modulo-kernels branch from 853bfca to fab398b Compare September 5, 2022 20:14
@jgehrcke
Copy link
Contributor

jgehrcke commented Dec 15, 2022 •
edited
Loading

Modulo (to me) seems like a rather important operator to be implemented. I'd love to help, if I can!

@jgehrcke jgehrcke mentioned this pull request Dec 15, 2022
Merged
@edponce edponce force-pushed the ARROW-12755-Compute-Add-quotient-and-modulo-kernels branch from e5b9b0b to 44d4445 Compare December 15, 2022 13:55
@asfimport asfimport mentioned this pull request Dec 15, 2022
Open
@jgehrcke
Copy link
Contributor

jgehrcke commented Feb 14, 2023

Update: priorities shifted. I'd love to get back to this, but reality is that I won't be able to in the coming 1 month, at least.

@kou kou changed the title ARROW-12755: [C++][Compute] Add quotient and modulo kernels GH-28497: [C++][Compute] Add quotient and modulo kernels May 10, 2023
@github-actions
Copy link

github-actions bot commented May 10, 2023

@github-actions
Copy link

github-actions bot commented May 10, 2023

⚠️ GitHub issue #28497 has been automatically assigned in GitHub to PR creator.

@mike-jn
Copy link

mike-jn commented Dec 2, 2024

would be great to have this implemented. what is the reason the PR stalled?

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.

@github-actions github-actions bot added the Status: stale-warning Issues and PRs flagged as stale which are due to be closed if no indication otherwise label Dec 3, 2025
@github-actions github-actions bot closed this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Component: C++ Status: stale-warning Issues and PRs flagged as stale which are due to be closed if no indication otherwise

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++][Compute] Add quotient and modulo kernels

5 participants

@edponce @pitrou @ianmcook @jgehrcke @mike-jn