Skip to content

ARROW-12084: [C++][Compute] Add remainder and quotient compute::Function #11115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
edponce wants to merge 10 commits into from
Closed

ARROW-12084: [C++][Compute] Add remainder and quotient compute::Function #11115

edponce wants to merge 10 commits into from

Conversation

@edponce
Copy link
Contributor

@edponce edponce commented Sep 9, 2021

This PR adds compute functions "divmod" and "divmod_checked" to calculate the quotient and remainder as a single operation.

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

https://issues.apache.org/jira/browse/ARROW-12084

@edponce edponce force-pushed the ARROW-12084-Compute-Add-remainder-and-quotient-compu branch 2 times, most recently from 2117a9f to e42547c Compare September 21, 2021 21:39
@edponce
Copy link
Contributor Author

edponce commented Sep 21, 2021

@lidavidm Please review :)

FYI, PR is still missing tests.

lidavidm
lidavidm reviewed Sep 22, 2021
View reviewed changes
@edponce edponce mentioned this pull request Nov 10, 2021
Closed
@kszucs
Copy link
Member

kszucs commented Apr 21, 2022

@edponce shall we close this as stale?

@edponce
Copy link
Contributor Author

edponce commented Apr 21, 2022

@kszucs Do not mark this PR as stale. I had stopped working on it bc I had trouble figuring out how to output a StructArray from compute kernel, but I have a pretty good understanding now. I will take some time on Monday to finish this.

@ianmcook
Copy link
Member

ianmcook commented Jun 2, 2022

@edponce could you please make it a priority to complete this PR, or see if someone else can take it over? Thanks.

@edponce edponce force-pushed the ARROW-12084-Compute-Add-remainder-and-quotient-compu branch from b38aae3 to 843f68e Compare July 18, 2022 18:50
lidavidm
lidavidm reviewed Jul 19, 2022
View reviewed changes
@edponce edponce force-pushed the ARROW-12084-Compute-Add-remainder-and-quotient-compu branch from 17bf054 to d38f80d Compare September 5, 2022 21:03
@asfimport asfimport mentioned this pull request Oct 17, 2022
Open
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.

@github-actions github-actions bot added the Status: stale-warning Issues and PRs flagged as stale which are due to be closed if no indication otherwise label Nov 18, 2025
@github-actions github-actions bot closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm left review comments

@pitrou pitrou pitrou left review comments

Assignees

No one assigned

Labels

Component: C++ Status: stale-warning Issues and PRs flagged as stale which are due to be closed if no indication otherwise

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@edponce @kszucs @ianmcook @lidavidm @pitrou