Improve Playwright test patterns in dag-tasks.spec.ts#63445
Merged
choo121600 merged 2 commits intoMar 20, 2026
Merged
Conversation
Contributor
Author
|
Hi @choo121600, could you please review this PR and let me know if you have any feedback? |
Contributor
Author
|
@choo121600 Is it okay if I pick up more issues? |
choo121600
reviewed
Mar 13, 2026
choo121600
left a comment
Member
There was a problem hiding this comment.
It looks like the CI is failing. Could you take a look?
Member
|
You can also run and debug the tests locally using the files here: |
Contributor
Author
|
@choo121600 I saw that #63559 was merged and it already addresses the |
fat-catTW
pushed a commit
to fat-catTW/airflow
that referenced
this pull request
Mar 22, 2026
… dag-tasks (apache#63445) Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
… dag-tasks (apache#63445) Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
abhijeets25012-tech
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
… dag-tasks (apache#63445) Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Playwright test patterns in
dag-tasks.spec.tsReplace anti-patterns in
DagsPage.tsanddag-tasks.spec.tswithPlaywright best practices:
:has-text()selectors withgetByRole()user-facing locatorspage.locator('[data-testid="..."]')withpage.getByTestId("...")page.waitForTimeout()with state-based waitslocator("a")withgetByRole("link")locator('div[role="listbox/option"]')withgetByRole().waitFor({ state: "visible" })withexpect().toBeVisible().dispatchEvent("click")with.click()locator("table")/locator("th")withgetByRole("table")/getByRole("columnheader")This PR focuses on improving test patterns only. It does not change test
coverage or behavior.
Part of #63036.
closes: #63425
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.