feat: Replace Playwright anti-patterns with web-first assertions in dag-list#63559
Merged
choo121600 merged 20 commits intoMar 19, 2026
Merged
feat: Replace Playwright anti-patterns with web-first assertions in dag-list#63559choo121600 merged 20 commits into
choo121600 merged 20 commits into
Conversation
Contributor
Author
|
@choo121600 Please review this PR. Welcome to any feedback! |
choo121600
reviewed
Mar 14, 2026
choo121600
left a comment
Member
There was a problem hiding this comment.
It looks like the static check is failing.
You might find the following guide helpful in resolving it :)
https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst
Contributor
Author
|
@choo121600 Please re-run test again. |
Contributor
Author
|
@choo121600 could you review and test again? |
…2e-improve-playwright-patterns-dags-list
choo121600
reviewed
Mar 17, 2026
choo121600
left a comment
Member
There was a problem hiding this comment.
Overall looks good 👍
just one
choo121600
reviewed
Mar 17, 2026
…2e-improve-playwright-patterns-dags-list
Contributor
Author
|
Thanks @choo121600 I updated! Please review again |
Contributor
Author
|
@choo121600 These testings don't seem to relate to my code changes. I'd appreciate you review that log and give me feedbacks. |
Member
|
You can reproduce and debug this locally using the following command: |
choo121600
reviewed
Mar 18, 2026
…2e-improve-playwright-patterns-dags-list
…2e-improve-playwright-patterns-dags-list
…2e-improve-playwright-patterns-dags-list
Contributor
Author
|
@choo121600 I updated. Please review the testing failure log. I think it doesn't seem to relate to my changes. |
choo121600
reviewed
Mar 19, 2026
choo121600
left a comment
Member
There was a problem hiding this comment.
It looks like the static check is failing.
…2e-improve-playwright-patterns-dags-list
Contributor
Author
|
@choo121600 please review again. Testing passed. thanks |
choo121600
approved these changes
Mar 19, 2026
Member
|
Cool, Thanks 🎉 |
1 task
fat-catTW
pushed a commit
to fat-catTW/airflow
that referenced
this pull request
Mar 22, 2026
…ag-list (apache#63559) * E2E: Replace Playwright anti-patterns with web-first assertions in dags-list * fix: solve PROD Image test error * fix: Fix remaining Playwright anti-patterns in DagsPage * fix: fix lint error * fix: Update stale breeze command output hash * fix: Use getByRole for card/table view toggle buttons * fix: Replace fragile state locator with data-testid and remove redundant .catch() wrappers * fix: update * fix: use data-testid and data-state assertions * fix: solve testing error * update * update * fix hook format
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
…ag-list (apache#63559) * E2E: Replace Playwright anti-patterns with web-first assertions in dags-list * fix: solve PROD Image test error * fix: Fix remaining Playwright anti-patterns in DagsPage * fix: fix lint error * fix: Update stale breeze command output hash * fix: Use getByRole for card/table view toggle buttons * fix: Replace fragile state locator with data-testid and remove redundant .catch() wrappers * fix: update * fix: use data-testid and data-state assertions * fix: solve testing error * update * update * fix hook format
abhijeets25012-tech
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
…ag-list (apache#63559) * E2E: Replace Playwright anti-patterns with web-first assertions in dags-list * fix: solve PROD Image test error * fix: Fix remaining Playwright anti-patterns in DagsPage * fix: fix lint error * fix: Update stale breeze command output hash * fix: Use getByRole for card/table view toggle buttons * fix: Replace fragile state locator with data-testid and remove redundant .catch() wrappers * fix: update * fix: use data-testid and data-state assertions * fix: solve testing error * update * update * fix hook format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Playwright anti-patterns with web-first assertions in
dags-list.spec.tsandDagsPage.tsto align with Playwright best practices. No test coverage or behavior changes.waitForTimeout()calls - replaced with state-based waiting (expect().toBeVisible/Hidden/toHaveCount,waitForResponse):has-text()andlocator("text=")withgetByRole(),getByTestId(), and.filter({ hasText: })verifyDagExists,verifyCardViewVisible,verifyTableViewVisible) toPromise<void>with web-firstexpect()assertionswhileloop +waitForTimeoutpolling inverifyDagRunStatuswithexpect.poll()needsReviewFilterselector (button:has-text("Needs Review")→getByTestId("dags-needs-review-filter"))closes: #63426
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-sonnet-4-6) following the guidelines