feat(ui): add DAG run state filter to grid view options#55898
Merged
jscheffl merged 3 commits intoSep 20, 2025
Conversation
Add filtering by DAG run state (queued, running, success, failed) to the grid view options panel, following the same pattern as the existing DagRuns.tsx implementation.
9342909 to
0c6018b
Compare
jscheffl
reviewed
Sep 19, 2025
jscheffl
approved these changes
Sep 19, 2025
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Looks good for me, tests are positive.
guan404ming
reviewed
Sep 20, 2025
guan404ming
left a comment
Member
There was a problem hiding this comment.
Overall looks good to me. Could you help take a look if this change is worked well with gantt chart? Thanks!
jason810496
approved these changes
Sep 20, 2025
jason810496
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! LGTM on API side.
…#55845 The issue was that the Gantt chart wasn't using the same filters as the Grid view. When you set a DAG run state filter in the Options menu, it would filter the Grid view but not the Gantt chart. Now both views will be synchronized with the same filtering criteria.
Member
Author
Good catch! I pushed a fix similar to #55845 fix.gantt.mp4 |
KatalKavya96
pushed a commit
to KatalKavya96/airflow
that referenced
this pull request
Sep 22, 2025
* feat(ui): add DAG run state filter to grid view options Add filtering by DAG run state (queued, running, success, failed) to the grid view options panel, following the same pattern as the existing DagRuns.tsx implementation. * Add testsgit add . * Gantt chart filtering issue by applying the same pattern as PR apache#55845 The issue was that the Gantt chart wasn't using the same filters as the Grid view. When you set a DAG run state filter in the Options menu, it would filter the Grid view but not the Gantt chart. Now both views will be synchronized with the same filtering criteria.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add filtering by DAG run state (queued, running, success, failed) to the grid view options panel, following the same pattern as the existing DagRuns.tsx implementation.